RFR [10] 8195823: Buffers given to response body subscribers should not contain unprocessed HTTP data

2018-01-22 Thread Chris Hegarty
It has been observed that byte buffers passed to the response subscriber may contain unprocessed data in the area between the buffer's limit and its capacity. This can happen when: 1) reading chunked HTTP/1.1 response data 2) receiving HTTP/2 data frames for several streams It is problemati

Re: RFR [10] 8195823: Buffers given to response body subscribers should not contain unprocessed HTTP data

2018-01-22 Thread Daniel Fuchs
Hi Chris, This looks good to me. I believed you covered all the cases. I have also imported your patch, and verified that the two new tests you added were failing without the patch and passing with the patch applied. So if you ran that through mach5 I believe we're covered. best regards, -- d

Re: RFR [10] 8195823: Buffers given to response body subscribers should not contain unprocessed HTTP data

2018-01-22 Thread Michael McMahon
Looks fine to me Chris. - Michael On 22/01/2018, 16:56, Chris Hegarty wrote: It has been observed that byte buffers passed to the response subscriber may contain unprocessed data in the area between the buffer's limit and its capacity. This can happen when: 1) reading chunked HTTP/1.1 respons