Looks fine to me Chris.
- Michael
On 22/01/2018, 16:56, Chris Hegarty wrote:
It has been observed that byte buffers passed to the response
subscriber may contain unprocessed data in the area between
the buffer's limit and its capacity. This can happen when:
1) reading chunked HTTP/1.1 response data
2) receiving HTTP/2 data frames for several streams
It is problematic for many reasons, least of all is that the
asString and buffering subscribers accumulate bytes, below a
certain threshold, into given buffers ( so as to not necessarily
consumer memory ). There could also be other, more serious,
issues.
http://cr.openjdk.java.net/~chegar/8195823/webrev.01/index.html
<http://cr.openjdk.java.net/%7Echegar/8195823/webrev.01/index.html>
-Chris.
P.S. I will seek the required approval for 10 RDP 2 post code
review.