Re: RFR 8193365: Improve interoperability between HTTP Client's BodyPublisher/BodySubscriber and Flow.Subscriber/Publisher

2017-12-20 Thread Daniel Fuchs
Hi Chris, This looks good to me. I wonder if the implementations of Susbscriber in the tests should be strengthened. I see that onError or onNext could throw exception - and though SubscriberAdapter seems to (partly) cater for it in onError, it doesn't do anything for onNext. I also wonder if t

Re: RFR 8193365: Improve interoperability between HTTP Client's BodyPublisher/BodySubscriber and Flow.Subscriber/Publisher

2017-12-20 Thread Chris Hegarty
Thanks for the review Daniel. On 20/12/17 09:29, Daniel Fuchs wrote: Hi Chris, This looks good to me. I wonder if the implementations of Susbscriber in the tests should be strengthened. Yes, I think so. I see that onError or onNext could throw exception - and though SubscriberAdapter seems