Re: RFR 8175814: HttpClient protocol version needs unspecified value

Hi Michael, On 26/04/2017 16:22, Michael McMahon wrote: Hi, This webrev has been updated with a number of additional changes since the first review. The latest webrev is at: http://cr.openjdk.java.net/~michaelm/8175814/webrev.3/index.html The updates look good to me. Might be good to have an

Re: JDK10 RFR: 8165437 Evaluate the use of gettimeofday in Networking code

> On 27 Apr 2017, at 05:15, Vyom Tewari wrote: > > Hi, > > please find the updated > webrev(http://cr.openjdk.java.net/~vtewari/8165437/webrev0.7/index.html). This looks ok to me Vyom, but I think you have misinterpreted my comment... >> ... >> 1) src/java.base/unix/native/libnet/PlainSocket

RFR [9] 8179392: Fix warnings in the httpclient javadoc

A few @param and @return tags have missing descriptions. The description wording, in a few cases, has just been taken from sibling method descriptions ( nothing new here ). http://cr.openjdk.java.net/~chegar/8179392/ -Chris.

Re: RFR [9] 8179392: Fix warnings in the httpclient javadoc

Looks good Chris! Maybe the copyright year should be updated as well? cheers, -- daniel On 27/04/2017 11:53, Chris Hegarty wrote: A few @param and @return tags have missing descriptions. The description wording, in a few cases, has just been taken from sibling method descriptions ( nothing ne

Re: JDK10 RFR: 8165437 Evaluate the use of gettimeofday in Networking code

Hello, It looks to me like using nanoseconds in the NET_Timeout Timeout Parameter would remove quite a few conversions. Callsides mostly already have timeoutNanoseconds for calculating reminder. Gruss Bernd -- http://bernd.eckenfels.net From: net-dev mailto:ne

Re: RFR [9] 8179392: Fix warnings in the httpclient javadoc

> On 27 Apr 2017, at 11:56, Daniel Fuchs wrote: > > Looks good Chris! > > Maybe the copyright year should be updated as well? Thanks for the review Daniel. I updated the copyright years before pushing. -Chris. > cheers, > > -- daniel > > On 27/04/2017 11:53, Chris Hegarty wrote: >> A few @

Re: JDK10 RFR: 8165437 Evaluate the use of gettimeofday in Networking code

Hi, Even i thought the same, pass nanosecond timeout to "NET_Timeout" but if you see the implementation it uses " *int poll(struct pollfd **/fds/*, nfds_t */nfds/*, int */timeout/*);* " where timeout is in millisecond so we have to do conversion anyway in loop if we pass timeout in NS. So t

Re: RFR 8175814: HttpClient protocol version needs unspecified value

> On 27 Apr 2017, at 10:18, Daniel Fuchs wrote: > > Hi Michael, > > On 26/04/2017 16:22, Michael McMahon wrote: >> Hi, >> >> This webrev has been updated with a number of additional changes since >> the first review. >> >> The latest webrev is at: >> http://cr.openjdk.java.net/~michaelm/81758

Re: RFR 8175814: HttpClient protocol version needs unspecified value

Hi Chris, Comments below On 27/04/2017, 14:32, Chris Hegarty wrote: On 27 Apr 2017, at 10:18, Daniel Fuchs wrote: Hi Michael, On 26/04/2017 16:22, Michael McMahon wrote: Hi, This webrev has been updated with a number of additional changes since the first review. The latest webrev is at: h

Re: RFR 8175814: HttpClient protocol version needs unspecified value

> On 27 Apr 2017, at 16:41, Michael McMahon > wrote: > > ... >> 4) AsyncConnection / Queue >> >> I find the term ‘block’ confusing here. It seems that the input channel, >> in the AsyncSSLDelegate implicitly puts itself into “blocking” mode >> when performing the initial handshake. The u

RE: JDK10 RFR: 8165437 Evaluate the use of gettimeofday in Networking code

Hi Vyom, I’ve just got a small formatting remark about the order of includes: Generally I tried to follow the rule 1. Common os headers, 2. Platform os headers, 3. Jvm/jdk headers, 4. JNI headers in my latest refactorings. So, to keep this up, can you move #include “jvm.h” in the line before #