> On 27 Apr 2017, at 05:15, Vyom Tewari <vyom.tew...@oracle.com> wrote:
>
> Hi,
>
> please find the updated
> webrev(http://cr.openjdk.java.net/~vtewari/8165437/webrev0.7/index.html).
This looks ok to me Vyom, but I think you have misinterpreted my comment...
>> ...
>> 1) src/java.base/unix/native/libnet/PlainSocketImpl.c
>>
>> L235 jlong nanoTimeout = timeout * NET_NSEC_PER_MSEC;
>>
>> Can you please move this to the latest block of code that requires it,
>> i.e..
>> just after L327 if (connect_rv != 0) { …
You seem to have moved this line too far, the declaration should
be at the beginning of the if block, just before the prevNanoTime
declaration and assignment. No need for another webrev, you
can just change it before pushing.
-Chris.
