Re: JDK10 RFR: 8165437 Evaluate the use of gettimeofday in Networking code

2017-04-13 Thread Thomas Stüfe
Hi Vyom, Thank you for fixing this! In addition to Rogers remarks: aix_close.c: Could you please also update the SAP copyright? style nit: +//nanoTimeout has to be >= 1 millisecond to iterate again. I thought we use old C style comments? Could you please leave a space between commen

Re: RFR [9] 8177536: Avoid Apple Peer-to-Peer interfaces in networking tests

2017-04-13 Thread Michael McMahon
Nice tidy up Chris. I guess we can add additional variants later to NetworkConfiguration::probe which return interfaces that are point to point or are down etc. Also, trivially, the two tests os system property "os.name" could be made consistent. I think it's one that is always guaranteed to b

Re: RFR [9] 8177536: Avoid Apple Peer-to-Peer interfaces in networking tests

2017-04-13 Thread Chris Hegarty
> On 12 Apr 2017, at 16:17, Roger Riggs wrote: > .. > B6558853.java: 28: an extra "*" > > A few tests do nothing unless an interface is found; they could use either > output that says what > interface is tested or a message that no interface was available. > (In case someone is reviewing the lo