Nice tidy up Chris. I guess we can add additional variants later to
NetworkConfiguration::probe which return interfaces that are point to
point or are down etc.
Also, trivially, the two tests os system property "os.name" could be
made consistent.
I think it's one that is always guaranteed to be set, or if not, then
both accesses could
return the same "unknown" string.
- Michael.
On 12/04/2017, 14:56, Chris Hegarty wrote:
This is a tests only change.
Several networking tests appear to fail intermittently on recent
Mac machines. In most cases an Apple Peer-to-Peer, awdl0,
interface, has been seen to be chosen by the test, for some
operation or other, when enumerating the set of network
interfaces on the machine. Such an interface may not be
suitable to perform the operation required by the test, and
thus best avoided.
http://cr.openjdk.java.net/~chegar/8177536.00/
<http://cr.openjdk.java.net/%7Echegar/8177536.00/>
This change attempts to create a NetworkConfiguration utility
class that can be expanded on to centralize the logic for most
networking related tests. For now, I’ve done the minimum
possible here to get the tests back to a reasonable shape, but
I expect that we can do further clean up and consolidation in the
future.
-Chris.
