RFR: 8167457: Fixes for InetAddressImpl native coding on Windows

2016-11-30 Thread Langer, Christoph
Hi, please finally review the change for 8167457. I made a new webrev: http://cr.openjdk.java.net/~clanger/webrevs/8167457.1/ In the new version I also touched the isReachable coding to do some cleanups and fix coverity code scan issues. I also updated Bug 8167457 to be more generic and enumer

RFR: 8167420: Fixes for InetAddressImpl native coding on Linux/Unix platforms

2016-11-30 Thread Langer, Christoph
Hi, please finally review the change for 8167420. (Windows counterpart of 8167457) I made a new webrev: http://cr.openjdk.java.net/~clanger/webrevs/8167420.2/ In the new version I also touched the isReachable coding to do some cleanups and fix coverity code scan issues. I also updated Bug 81674

RFR: 8170544: Fix code scan findings in libnet

2016-11-30 Thread Langer, Christoph
Hi, please review the following change: Bug: https://bugs.openjdk.java.net/browse/JDK-8170544 Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8170544.0/ With this change I change some function signatures to use SOCKETADDRESS * instead of struct sockaddr * where appropriate. This fixes some

Re: RFR: 8170544: Fix code scan findings in libnet

2016-11-30 Thread Michael McMahon
I will run the change through JPRT Christoph Thanks Michael On 30/11/2016, 16:32, Langer, Christoph wrote: Hi, please review the following change: Bug: https://bugs.openjdk.java.net/browse/JDK-8170544 Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8170544.0/

RE: RFR: 8170544: Fix code scan findings in libnet

2016-11-30 Thread Langer, Christoph
Thanks, Michael. Maybe you can run all the 3 together: http://cr.openjdk.java.net/~clanger/webrevs/8167457.1/ http://cr.openjdk.java.net/~clanger/webrevs/8167420.2/ http://cr.openjdk.java.net/~clanger/webrevs/8170544.0/ 8170544 comes atop 8167420 (though it's just a small clash). Best regards