Thanks, Michael. Maybe you can run all the 3 together:
http://cr.openjdk.java.net/~clanger/webrevs/8167457.1/ http://cr.openjdk.java.net/~clanger/webrevs/8167420.2/ http://cr.openjdk.java.net/~clanger/webrevs/8170544.0/ 8170544 comes atop 8167420 (though it's just a small clash). Best regards Christoph From: Michael McMahon [mailto:michael.x.mcma...@oracle.com] Sent: Mittwoch, 30. November 2016 17:57 To: Langer, Christoph <christoph.lan...@sap.com> Cc: net-dev@openjdk.java.net; Chris Hegarty <chris.hega...@oracle.com>; Lindenmaier, Goetz <goetz.lindenma...@sap.com> Subject: Re: RFR: 8170544: Fix code scan findings in libnet I will run the change through JPRT Christoph Thanks Michael On 30/11/2016, 16:32, Langer, Christoph wrote: Hi, please review the following change: Bug: https://bugs.openjdk.java.net/browse/JDK-8170544 Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8170544.0/<http://cr.openjdk.java.net/%7Eclanger/webrevs/8170544.0/> With this change I change some function signatures to use SOCKETADDRESS * instead of struct sockaddr * where appropriate. This fixes some code scan findings, which reported the fact that it's dangerous to pass struct socaddr * pointers and then cast it to the wider struct sockaddr_in6. I think this makes the code cleaner and spares some casts at several places. Please review and run through JPRT testing. Thanks Christoph
