> On 19 Oct 2016, at 16:29, Daniel Fuchs wrote:
>
> Thanks Roger!
>
> On 19/10/16 16:01, Roger Riggs wrote:
>> Hi Daniel,
>>
>> looks fine.
>>
>> (The style differences are disconcerting but are consistent within the
>> file).
>
> Yes. I preserved the original style though it was hurting
> m
sun/net/www/protocol/jar/B4957695.java
This test is to verify that no jar_cache tmpFile left in temp directory
when IOException occurs.
Test do stream reading and trigger IOException and compare the jar_cache
file number before and after this action (that triggered the IOException):
> On 20 Oct 2016, at 11:45, Amy Lu wrote:
>
> sun/net/www/protocol/jar/B4957695.java
>
> This test is to verify that no jar_cache tmpFile left in temp directory when
> IOException occurs.
>
> Test do stream reading and trigger IOException and compare the jar_cache file
> number before and af
Hello,
Could you please review the following change for [1]?
http://cr.openjdk.java.net/~prappo/8168405/webrev/
This change addresses some code paths in the native networking code for Windows
operating system where thrown exceptions might be left unnoticed.
Thanks,
-Pavel
--
Hi Pavel,
overall this looks good. I've got a few minor remarks:
1. What about using the macro CHECK_NULL_RETURN in NetworkInterface_winXP.c?
2. in Java_java_net_TwoStacksPlainDatagramSocketImpl_peekData:
You could move
1178 /* make sure receive() picks up the right fd */
1179 (*env)->S
> On 20 Oct 2016, at 14:03, Langer, Christoph wrote:
>
> Hi Pavel,
>
> overall this looks good. I've got a few minor remarks:
>
> 1. What about using the macro CHECK_NULL_RETURN in NetworkInterface_winXP.c?
>
> 2. in Java_java_net_TwoStacksPlainDatagramSocketImpl_peekData:
>
> You could move
Hi Pavel,
> > On 20 Oct 2016, at 14:03, Langer, Christoph
> wrote:
> >
> > Hi Pavel,
> >
> > overall this looks good. I've got a few minor remarks:
> >
> > 1. What about using the macro CHECK_NULL_RETURN in
> NetworkInterface_winXP.c?
> >
> > 2. in Java_java_net_TwoStacksPlainDatagramSocketImpl_p
Chris,
I created a new version that addresses your points:
http://cr.openjdk.java.net/~clanger/webrevs/8167481.1/
I reordered the headers according to your suggestions ( 1) system, 2) platform
specific includes, 3) JNI includes, and finally, 4) generated headers ), added
the @Native and removed
> On 20 Oct 2016, at 13:47, Pavel Rappo wrote:
>
> Hello,
>
> Could you please review the following change for [1]?
>
> http://cr.openjdk.java.net/~prappo/8168405/webrev/
Thank you Pavel, this looks good.
-Chris.
> This change addresses some code paths in the native networking code for
>
