Hi Pavel, overall this looks good. I've got a few minor remarks:
1. What about using the macro CHECK_NULL_RETURN in NetworkInterface_winXP.c? 2. in Java_java_net_TwoStacksPlainDatagramSocketImpl_peekData: You could move 1178 /* make sure receive() picks up the right fd */ 1179 (*env)->SetIntField(env, this, pdsi_fduseID, fduse); into the else branch above and set port to -1 in the n<0 branches. That way -1 will be returned always and the free(fullPacket) is also invoked if necessary with less lines of code :) But that's probably a matter of taste ;-) Best regards Christoph > -----Original Message----- > From: Pavel Rappo [mailto:pavel.ra...@oracle.com] > Sent: Donnerstag, 20. Oktober 2016 14:47 > To: OpenJDK Network Dev list <net-dev@openjdk.java.net> > Subject: RFR 8168405: Pending exceptions in java.base/windows/native > > Hello, > > Could you please review the following change for [1]? > > http://cr.openjdk.java.net/~prappo/8168405/webrev/ > > This change addresses some code paths in the native networking code for > Windows > operating system where thrown exceptions might be left unnoticed. > > Thanks, > -Pavel > > -------------------------------------------------------------------------------- > [1] https://bugs.openjdk.java.net/browse/JDK-8168405
