RFR(S): 8167420: remove redundant code path in unix/native/libnet/Inet4AddressImpl.c

2016-10-10 Thread Langer, Christoph
Hi, here's another review request for a cleanup: Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8167420.0/ Bug: https://bugs.openjdk.java.net/browse/JDK-8167420 In unix/native/libnet/Inet4AddressImpl.c, there exist 2 implementations for each of Java_java_net_Inet4AddressImpl_getLocalHostNa

Re: RFR(L): 8167295: Further cleanup to the native parts of libnet/libnio

2016-10-10 Thread Chris Hegarty
Hi Christoph, On 07/10/16 16:17, Langer, Christoph wrote: Hi again, I have respun my patch a little bit: http://cr.openjdk.java.net/~clanger/webrevs/8167295.1/ This is a nice cleanup and an improvement to the code. Specifically, adding 'struct sockaddr sa' to SOCKETADDRESS allows for the remo

RE: RFR(L): 8167295: Further cleanup to the native parts of libnet/libnio

2016-10-10 Thread Langer, Christoph
Hi Chris, thanks for the review. We couldn't observe issues in our OpenJDK test systems and most of the change was part of the SAP JVM already for quite some time. So I pushed it just now: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/d4f70e7859c7 Some more cleanup is still to come... :) Best r