Hi, here's another review request for a cleanup:
Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8167420.0/ Bug: https://bugs.openjdk.java.net/browse/JDK-8167420 In unix/native/libnet/Inet4AddressImpl.c, there exist 2 implementations for each of Java_java_net_Inet4AddressImpl_getLocalHostName, Java_java_net_Inet4AddressImpl_lookupAllHostAddr and Java_java_net_Inet4AddressImpl_getHostByAddr. I think one branch is obsolete. I also did some cleanups in those functions. One question that I still have is if we should add the MACOSX workaround path when getaddrinfo returns error and "lookupIfLocalhost" is called? However, as it was not part of the standard branch which is probably used mostly on MacOSX nowadays, I tend to remove it. In the webrev it is still contained. The changeset is based on my proposal for 8167295<https://bugs.openjdk.java.net/browse/JDK-8167295> (http://cr.openjdk.java.net/~clanger/webrevs/8167295.1/). Thanks & Best regards Christoph
