RFR 8133704/9, java/net/DatagramSocket/SetDatagramSocketImplFactory/ADatagramSocket.java may fail with address already in use

2016-01-08 Thread Felix Yang
Hi all, please review the fix for java/net/DatagramSocket/SetDatagramSocketImplFactory/ADatagramSocket.java Bug: https://bugs.openjdk.java.net/browse/JDK-8133704 Webrev: http://cr.openjdk.java.net/~xiaofeya/8133704/webrev.00 It is using hard-coded port 4445 for the server side. This fix upda

Re: RFR 8133704/9, java/net/DatagramSocket/SetDatagramSocketImplFactory/ADatagramSocket.java may fail with address already in use

2016-01-08 Thread Chris Hegarty
Hi Felix, On 08/01/16 08:36, Felix Yang wrote: Hi all, please review the fix for java/net/DatagramSocket/SetDatagramSocketImplFactory/ADatagramSocket.java Bug: https://bugs.openjdk.java.net/browse/JDK-8133704 Webrev: http://cr.openjdk.java.net/~xiaofeya/8133704/webrev.00 This looks good.

RFR: 8146686: Create the schemeSpecificPart for non-opaque URIs lazily

2016-01-08 Thread Claes Redestad
Hi, please review this patch to lazily create schemeSpecificPart for non-opaque URIs. This change accounts for some improvement in footprint characteristics and a 10-20% improvement on URI creation microbenchmarks, while not regressing notably on a targetted microbenchmark which explicitly ge

Re: RFR: 8146686: Create the schemeSpecificPart for non-opaque URIs lazily

2016-01-08 Thread Alan Bateman
On 08/01/2016 14:41, Claes Redestad wrote: Hi, please review this patch to lazily create schemeSpecificPart for non-opaque URIs. This change accounts for some improvement in footprint characteristics and a 10-20% improvement on URI creation microbenchmarks, while not regressing notably on a

Re: RFR: 8146686: Create the schemeSpecificPart for non-opaque URIs lazily

2016-01-08 Thread Claes Redestad
On 2016-01-08 16:34, Alan Bateman wrote: On 08/01/2016 14:41, Claes Redestad wrote: Hi, please review this patch to lazily create schemeSpecificPart for non-opaque URIs. This change accounts for some improvement in footprint characteristics and a 10-20% improvement on URI creation microben