On 2016-01-08 16:34, Alan Bateman wrote:
On 08/01/2016 14:41, Claes Redestad wrote:
Hi,
please review this patch to lazily create schemeSpecificPart for
non-opaque URIs. This change accounts for some improvement in
footprint characteristics and a 10-20% improvement on URI creation
microbenchmarks, while not regressing notably on a targetted
microbenchmark which explicitly generate and retrieve the
schemeSpecificPart.
Bug: https://bugs.openjdk.java.net/browse/JDK-8146686
Webrev: http://cr.openjdk.java.net/~redestad/8146686/webrev.01/
This looks okay to me. The only thing that I wonder about is the
original code returning null when getRawSchemeSpecificPart is
specified to never return null.
Yes, I think that can't ever happen for any valid URI since during parse
either schemeSpecificPart or path will be set to a non-null value. I
propagated this confusion in one of the recent patches to be
semantically identical with the legacy implementation.
/Claes
-Alan.
