Re: RFR 8131155/9, java/net/NetworkInterface/NetworkInterfaceStreamTest.java failed because of Teredo Tunneling Pseudo-Interface

2015-12-18 Thread Amy Lu
Change looks fine. Thank you for the update Felix. (But please wait for the final GO from one official reviewer.) Thanks, Amy On 12/16/15 1:35 PM, Felix Yang wrote: Chris/Paul/Amy, thank you very much for your comments. I produced a new webrev by 1) renaming isWindows to "IS_WINDOWS' 2) r

Re: RFR 8131155/9, java/net/NetworkInterface/NetworkInterfaceStreamTest.java failed because of Teredo Tunneling Pseudo-Interface

2015-12-18 Thread Paul Sandoz
> On 18 Dec 2015, at 10:42, Amy Lu wrote: > > Change looks fine. Thank you for the update Felix. > > (But please wait for the final GO from one official reviewer.) > +1 Amy, can you sponsor? Thanks, Paul. signature.asc Description: Message signed with OpenPGP using GPGMail

Re: RFR 8131155/9, java/net/NetworkInterface/NetworkInterfaceStreamTest.java failed because of Teredo Tunneling Pseudo-Interface

2015-12-18 Thread Amy Lu
On 12/18/15 6:07 PM, Paul Sandoz wrote: On 18 Dec 2015, at 10:42, Amy Lu wrote: Change looks fine. Thank you for the update Felix. (But please wait for the final GO from one official reviewer.) +1 Amy, can you sponsor? Thanks, Paul. Thank you Paul for review. Yes! I can push this for Fel

Re: RFR [9] 8143554: UnsupportedOperationException is not thrown for unsupported options

2015-12-18 Thread Svetlana Nikandrova
Alan, Michael, thank you for your feedback. As you suggested I moved checking code down to the implementation. Please see updated webrev: http://cr.openjdk.java.net/~kshefov/8143554/webrev.02/ Thank you, Svetlana On 08.12.2015 16:51,