Change looks fine. Thank you for the update Felix.
(But please wait for the final GO from one official reviewer.)
Thanks,
Amy
On 12/16/15 1:35 PM, Felix Yang wrote:
Chris/Paul/Amy,
thank you very much for your comments. I produced a new webrev by
1) renaming isWindows to "IS_WINDOWS'
2) removing @intermittent
3) adding 8131155 to @bug
Webrev: http://cr.openjdk.java.net/~xiaofeya/8131155/webrev.01/
If it is OK, I need a sponsor.
Thanks again,
Felix
On 2015/12/14 18:55, Paul Sandoz wrote:
On 14 Dec 2015, at 11:53, Chris Hegarty <chris.hega...@oracle.com>
wrote:
On 14/12/15 10:07, Paul Sandoz wrote:
Hi Felix,
Is it correct to filter out all network interfaces on windows
platforms?
I may be missing something, but this should ONLY filter out
interfaces with the name 'Teredo', on Windows. NOT ALL.
Doh yes, i missed the “!’.
Paul.
It is quite common for networking tests to exclude Teredo
interfaces, as they are unstable ( for testing purposes ).