Hi, Felix
I'm not openjdk reviewer, just a minor comment here.
You may want to remove "intermittent" key from this test along with your
fix.
- * @key intermittent
Thanks,
Amy
On 12/14/15 2:53 PM, Felix Yang wrote:
Hi all,
please review the fix for
java/net/NetworkInterface/NetworkInt
> On 14 Dec 2015, at 6:53 a.m., Felix Yang wrote:
>
> Hi all,
>please review the fix for
> java/net/NetworkInterface/NetworkInterfaceStreamTest.java. It is necessary to
> exclude "Teredo Tunneling Pseudo-Interface" whose configuration changes
> frequently.
>
> Bug: https://bugs.openjdk.j
Hi Felix,
Is it correct to filter out all network interfaces on windows platforms?
IIUC that renders the tests testSubNetworkInterfaces and testInetAddresses
redundant on windows.
If so it would be useful to document that on those tests.
Some minor suggestions:
s/isWindows/IS_WINDOWS
Colo
On 14/12/15 10:07, Paul Sandoz wrote:
Hi Felix,
Is it correct to filter out all network interfaces on windows platforms?
I may be missing something, but this should ONLY filter out
interfaces with the name 'Teredo', on Windows. NOT ALL.
It is quite common for networking tests to exclude Tere
> On 14 Dec 2015, at 11:53, Chris Hegarty wrote:
>
>
>
> On 14/12/15 10:07, Paul Sandoz wrote:
>> Hi Felix,
>>
>> Is it correct to filter out all network interfaces on windows platforms?
>
> I may be missing something, but this should ONLY filter out
> interfaces with the name 'Teredo', on W
