Re: RFR for bug JDK-8025209 Intermittent test failure: java/net/Socket/asyncClose/AsyncClose.java

2014-03-28 Thread Chris Hegarty
Hi Eric, I've taken a look at the webrev and I mainly agree with the changes/refactoring. On the issue of increasing the timeout to 20 secs; there is a clear race in this test, and your refactoring has reduced it as much as possible. Since the sleep will always occur, I would prefer to reduc

Re: RFR for JDK-8038276 java/net/NetworkInterface/Test.java fails on windows intermittently for Teredo Interface

2014-03-28 Thread Chris Hegarty
Looks ok to me Amanda. I can sponsor this change, if needed. -Chris. On 28/03/14 05:07, Amanda Jiang wrote: Hi All , Please check and review following changes: http://cr.openjdk.java.net/~ewang/amanda/JDK-8038276/webrev.00/ Description of issue: Root Cause: Test java/net/NetworkInterface/Test

Re: RFR for JDK-8038276 java/net/NetworkInterface/Test.java fails on windows intermittently for Teredo Interface

2014-03-28 Thread Amanda Jiang
Please sponsor this change . Thank you, Chris. Amanda On 3/28/14 6:10 AM, Chris Hegarty wrote: Looks ok to me Amanda. I can sponsor this change, if needed. -Chris. On 28/03/14 05:07, Amanda Jiang wrote: Hi All , Please check and review following changes: http://cr.openjdk.java.net/~ewang/am