Re: RFR: simple javadoc cleanup in java.net

2013-12-18 Thread roger riggs
Thanks Alan, I corrected the webrev to link both locations that refer to ProxySelector. http://cr.openjdk.java.net/~rriggs/webrev-javadoc-link-7018010/ Roger On 12/18/2013 6:23 AM, Alan Bateman wrote: On 17/12/2013 22:35, roger riggs wrote: Please review, an easy one, just 1 less bug on th

Re: RFR: simple javadoc cleanup in java.net

2013-12-18 Thread Alan Bateman
On 18/12/2013 14:35, roger riggs wrote: Thanks Alan, I corrected the webrev to link both locations that refer to ProxySelector. http://cr.openjdk.java.net/~rriggs/webrev-javadoc-link-7018010/ Looks good. -Alan

RFR:JDK-7102702 - java/net/PortUnreachableException/OneExceptionOnly.java failing

2013-12-18 Thread Mark Sheppard
Hi, please oblige and review the following changes http://cr.openjdk.java.net/~msheppar/7102702/webrev/ to address the issue https://bugs.openjdk.java.net/browse/JDK-7102702 This test fails on windows, and it was found to be failing with an error WSAEFAULT (10014), when invoking a recvfro

Re: RFR:JDK-7102702 - java/net/PortUnreachableException/OneExceptionOnly.java failing

2013-12-18 Thread Alan Bateman
On 18/12/2013 15:09, Mark Sheppard wrote: Hi, please oblige and review the following changes http://cr.openjdk.java.net/~msheppar/7102702/webrev/ Good sleuthing!! The change looks good to me. -Alan.

Re: RFR:JDK-7102702 - java/net/PortUnreachableException/OneExceptionOnly.java failing

2013-12-18 Thread Chris Hegarty
On 18 Dec 2013, at 15:13, Alan Bateman wrote: > On 18/12/2013 15:09, Mark Sheppard wrote: >> >> Hi, >> please oblige and review the following changes >> >> http://cr.openjdk.java.net/~msheppar/7102702/webrev/ > Good sleuthing!! The change looks good to me. Yes, this is a good find, and the c

Re: RFR: simple javadoc cleanup in java.net

2013-12-18 Thread Chris Hegarty
On 18 Dec 2013, at 14:35, roger riggs wrote: > Thanks Alan, > > I corrected the webrev to link both locations that refer to ProxySelector. > http://cr.openjdk.java.net/~rriggs/webrev-javadoc-link-7018010/ Looks good. Thanks Roger. -Chris. > > Roger > > On 12/18/2013 6:23 AM, Alan Bateman

Re: RFR:JDK-7102702 - java/net/PortUnreachableException/OneExceptionOnly.java failing

2013-12-18 Thread Mark Sheppard
potentially the same issue with TwoStacksPlainDatagramSocketImpl for an IPV6 address. as I have only ever enabled TwoStack via -Djava.net.preferIPv4Stack=true then the sockaddr_in is sufficient to hold an IPV4 address If we think it worthwhile, I can make the equivalent change in TwoStack, and

Re: RFR:JDK-7102702 - java/net/PortUnreachableException/OneExceptionOnly.java failing

2013-12-18 Thread Chris Hegarty
On 18 Dec 2013, at 16:19, Mark Sheppard wrote: > potentially the same issue with > > TwoStacksPlainDatagramSocketImpl > > for an IPV6 address. > > as I have only ever enabled TwoStack via -Djava.net.preferIPv4Stack=true > then the sockaddr_in is sufficient to hold an IPV4 address It is only a

Re: RFR:JDK-7102702 - java/net/PortUnreachableException/OneExceptionOnly.java failing

2013-12-18 Thread Alan Bateman
On 18/12/2013 16:19, Mark Sheppard wrote: potentially the same issue with TwoStacksPlainDatagramSocketImpl for an IPV6 address. as I have only ever enabled TwoStack via -Djava.net.preferIPv4Stack=true then the sockaddr_in is sufficient to hold an IPV4 address If we think it worthwhile, I can

Re: RFR:JDK-7102702 - java/net/PortUnreachableException/OneExceptionOnly.java failing

2013-12-18 Thread Michael McMahon
On 18/12/13 16:27, Alan Bateman wrote: On 18/12/2013 16:19, Mark Sheppard wrote: potentially the same issue with TwoStacksPlainDatagramSocketImpl for an IPV6 address. as I have only ever enabled TwoStack via -Djava.net.preferIPv4Stack=true then the sockaddr_in is sufficient to hold an IPV4 ad

hg: jdk8/tl/jdk: 7093640: Enable client-side TLS 1.2 by default

2013-12-18 Thread xuelei . fan
Changeset: 8d35f0985dd7 Author:xuelei Date: 2013-12-18 16:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8d35f0985dd7 7093640: Enable client-side TLS 1.2 by default Reviewed-by: weijun, mullan, wetmore ! src/share/classes/sun/security/ssl/ProtocolVersion.java ! src/share/