On 18 Dec 2013, at 16:19, Mark Sheppard <mark.shepp...@oracle.com> wrote:
> potentially the same issue with > > TwoStacksPlainDatagramSocketImpl > > for an IPV6 address. > > as I have only ever enabled TwoStack via -Djava.net.preferIPv4Stack=true > then the sockaddr_in is sufficient to hold an IPV4 address It is only applicable on Windows XP with IPv6 enabled. > If we think it worthwhile, > I can make the equivalent change in TwoStack, and re-execute the regression > suites. I’d trivially just make the change, retest, and push. No need for another webrev. -Chris. > > regards > Mark > > On 18/12/2013 16:05, Chris Hegarty wrote: >> On 18 Dec 2013, at 15:13, Alan Bateman <alan.bate...@oracle.com> wrote: >> >>> On 18/12/2013 15:09, Mark Sheppard wrote: >>>> Hi, >>>> please oblige and review the following changes >>>> >>>> http://cr.openjdk.java.net/~msheppar/7102702/webrev/ >>> Good sleuthing!! The change looks good to me. >> Yes, this is a good find, and the changes look good. >> >> Is there the same issue ( and fix ) in TwoStacksPlainDatagramSocketImpl.c >> also ? >> >> -Chris >> >>> -Alan. >
