8011234: Performance regression with ftp protocol when uploading in image mode

2013-04-03 Thread Alan Bateman
This is a small patch to the legacy ftp client to fix a performance regression that seems to have crept in when this code was refactored in jdk7. When uploading in image/binary mode (the default or when specifying type=i) then the URLConnection's getOutputStream method no longer returns an Ou

Re: 8011234: Performance regression with ftp protocol when uploading in image mode

2013-04-03 Thread Chris Hegarty
Thank you Alan, this change looks correct to me. -Chris. On 03/04/2013 10:37, Alan Bateman wrote: This is a small patch to the legacy ftp client to fix a performance regression that seems to have crept in when this code was refactored in jdk7. When uploading in image/binary mode (the default o

hg: jdk8/tl/jdk: 8011234: Performance regression with ftp protocol when uploading in image mode

2013-04-03 Thread alan . bateman
Changeset: c534937f6e94 Author:alanb Date: 2013-04-03 13:15 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c534937f6e94 8011234: Performance regression with ftp protocol when uploading in image mode Reviewed-by: chegar ! src/share/classes/sun/net/ftp/impl/FtpClient.java

hg: jdk8/tl/jdk: 8011373: Property java.runtime.profile should be removed (left-over code)

2013-04-03 Thread alan . bateman
Changeset: eb8f7bc6f964 Author:alanb Date: 2013-04-03 13:41 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eb8f7bc6f964 8011373: Property java.runtime.profile should be removed (left-over code) Reviewed-by: lancea, dholmes ! src/share/classes/sun/misc/Version.java.template

Re: DefaultProxySelector socks override

2013-04-03 Thread Kurchi Subhra Hazra
On 4/2/13 6:27 PM, chris...@zoulas.com wrote: On Apr 2, 5:26pm, kurchi.subhra.ha...@oracle.com (Kurchi Hazra) wrote: -- Subject: Re: DefaultProxySelector socks override | Also, I should have clarified why I am changing the test. Since now we | are defining the socks non-proxy property - | local

Re: DefaultProxySelector socks override

2013-04-03 Thread Chris Hegarty
Thank you Kurchi for taking this in, and running/updating the test. Do you think that anyone might be surprised by this change, like our test was? Wanting to proxy connections to the localhost seems more like testing environments rather than deployment. -Chris. On 04/03/2013 01:13 AM, Kurchi

hg: jdk8/tl/jdk: 7091601: Arabic Locale: can not set type of digit in application level

2013-04-03 Thread naoto . sato
Changeset: 9a6ef3391f32 Author:naoto Date: 2013-04-03 10:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9a6ef3391f32 7091601: Arabic Locale: can not set type of digit in application level Reviewed-by: okutsu ! src/macosx/native/sun/util/locale/provider/HostLocaleProviderA

hg: jdk8/tl/langtools: 8011052: Add DEFAULT to javax.lang.model.Modifier

2013-04-03 Thread joe . darcy
Changeset: 0d47e6131490 Author:darcy Date: 2013-04-03 12:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0d47e6131490 8011052: Add DEFAULT to javax.lang.model.Modifier Reviewed-by: abuckley, jjg ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/clas

Re: DefaultProxySelector socks override

2013-04-03 Thread Christos Zoulas
On Apr 3, 9:15am, kurchi.subhra.ha...@oracle.com (Kurchi Subhra Hazra) wrote: -- Subject: Re: DefaultProxySelector socks override | Hi Christos, | | It is ok to push the test changes alongwith the code changes - we do not | want | to break our tests as a result of new changes.. | I am making an

Re: DefaultProxySelector socks override

2013-04-03 Thread Kurchi Subhra Hazra
So the default non-proxy hosts are localhost|127.*|[::1]|0.0.0.0|[::0]. There can thus be a problem only if the local machine is being used as a proxy, which will be unlikely in real environments. We could go a step further and allow setting socksNonProxyHosts to "" (an empty string) to overri

Re: DefaultProxySelector socks override

2013-04-03 Thread Kurchi Subhra Hazra
Sure Christos, I will include a comment in the test. I should also include the bug id in the jtreg tag, now that I am changing the test. - Kurchi On 4/3/13 1:22 PM, chris...@zoulas.com wrote: On Apr 3, 9:15am, kurchi.subhra.ha...@oracle.com (Kurchi Subhra Hazra) wrote: -- Subject: Re: Default

hg: jdk8/tl: 8011350: hgforest.sh uses non-POSIX sh features that may fail with some shells

2013-04-03 Thread mike . duigou
Changeset: 575f2ca947ab Author:mduigou Date: 2013-04-03 16:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/575f2ca947ab 8011350: hgforest.sh uses non-POSIX sh features that may fail with some shells Reviewed-by: tbell, katleman, dholmes ! common/bin/hgforest.sh