Re: RFR JDK-4880778

2013-02-04 Thread Chris Hegarty
On 02/02/2013 16:29, Alan Bateman wrote: On 02/02/2013 14:39, John Zavgren wrote: Greetings: Please consider the following modification of our classes for handling URLs. http://cr.openjdk.java.net/~jzavgren/4880778/webrev.01/ This looks okay to me. Yes, looks ok to me too. For the URLSt

Re: RFR JDK-4880778

2013-02-04 Thread John Zavgren
I posted a new webrev image: http://cr.openjdk.java.net/~jzavgren/4880778/webrev.02/ I made two changes: 1.) modified the indentation that's used for the argument list of the URL class set() methods. 2.) changed the documentation for the set method in the URLStreamHandler class. - Original

Re: RFR JDK-4880778

2013-02-04 Thread Chris Hegarty
Thanks John, Trivially, and unrelated to your changes but while you're there, I would really like to remove "are supposed to". < * Only classes derived from URLStreamHandler are supposed to be able < * to use this method to set the values of the URL fields. --- > * Only classes derived from UR

hg: jdk8/tl/jdk: 8006994: Cleanup PKCS12 tests to ensure streams get closed

2013-02-04 Thread vincent . x . ryan
Changeset: 5bf1c9e6be60 Author:vinnie Date: 2013-02-04 17:20 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5bf1c9e6be60 8006994: Cleanup PKCS12 tests to ensure streams get closed Reviewed-by: mullan ! test/java/security/KeyStore/PBETest.java ! test/sun/security/pkcs12/Store

Re: RFR JDK-4880778

2013-02-04 Thread John Zavgren
Chris: I made the documentation change: http://cr.openjdk.java.net/~jzavgren/4880778/webrev.03/ John - Original Message - From: chris.hega...@oracle.com To: john.zavg...@oracle.com Cc: net-dev@openjdk.java.net Sent: Monday, February 4, 2013 11:19:42 AM GMT -05:00 US/Canada Eastern Subject:

Re: RFR JDK-4880778

2013-02-04 Thread Chris Hegarty
Thank you John, looks good to me. -Chris. On 02/04/2013 05:24 PM, John Zavgren wrote: Chris: I made the documentation change: http://cr.openjdk.java.net/~jzavgren/4880778/webrev.03/ John - Original Message - From: chris.hega...@oracle.com To: john.zavg...@oracle.com Cc: net-dev@openjdk

hg: jdk8/tl/jdk: 8006295: Base64.Decoder.wrap(java.io.InputStream) returns InputStream which throws unspecified IOException on attempt to decode invalid Base64 byte stream; ...

2013-02-04 Thread xueming . shen
Changeset: e202f43a8b8a Author:sherman Date: 2013-02-04 11:58 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e202f43a8b8a 8006295: Base64.Decoder.wrap(java.io.InputStream) returns InputStream which throws unspecified IOException on attempt to decode invalid Base64 byte strea

hg: jdk8/tl/langtools: 8007490: NPE from DocumentationTool.run

2013-02-04 Thread jonathan . gibbons
Changeset: 1690928dc560 Author:jjg Date: 2013-02-04 15:30 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1690928dc560 8007490: NPE from DocumentationTool.run Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/api/JavadocTool.java ! test/tools/javadoc/api/basi

hg: jdk8/tl/jdk: 8007113: Upgrade AnnotatedElement.isAnnotionPresent to be a default method

2013-02-04 Thread joe . darcy
Changeset: e04467fa13af Author:darcy Date: 2013-02-04 17:56 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e04467fa13af 8007113: Upgrade AnnotatedElement.isAnnotionPresent to be a default method Reviewed-by: chegar, jfranck ! src/share/classes/java/lang/Class.java ! src/shar

hg: jdk8/tl/langtools: 8007492: DocumentationTool cannot locate standard doclet when invoked from JRE

2013-02-04 Thread jonathan . gibbons
Changeset: 62d91c13dce2 Author:jjg Date: 2013-02-04 18:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/62d91c13dce2 8007492: DocumentationTool cannot locate standard doclet when invoked from JRE Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/api/Javadoc

hg: jdk8/tl: Added tag jdk8-b75 for changeset 2a713921952c

2013-02-04 Thread lana . steuck
Changeset: 5b19cef637a6 Author:katleman Date: 2013-01-31 17:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/5b19cef637a6 Added tag jdk8-b75 for changeset 2a713921952c ! .hgtags

hg: jdk8/tl/corba: Added tag jdk8-b75 for changeset d4e68ce17795

2013-02-04 Thread lana . steuck
Changeset: 4a6be02e66a3 Author:katleman Date: 2013-01-31 17:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/4a6be02e66a3 Added tag jdk8-b75 for changeset d4e68ce17795 ! .hgtags

hg: jdk8/tl/jaxp: Added tag jdk8-b75 for changeset ff0b73a6b3f6

2013-02-04 Thread lana . steuck
Changeset: 8d65b381880b Author:katleman Date: 2013-01-31 17:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/8d65b381880b Added tag jdk8-b75 for changeset ff0b73a6b3f6 ! .hgtags

hg: jdk8/tl/hotspot: Added tag jdk8-b75 for changeset 6778d0b16593

2013-02-04 Thread lana . steuck
Changeset: 20b605466ccb Author:katleman Date: 2013-01-31 17:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/20b605466ccb Added tag jdk8-b75 for changeset 6778d0b16593 ! .hgtags

hg: jdk8/tl/langtools: 2 new changesets

2013-02-04 Thread lana . steuck
Changeset: 716935fec613 Author:katleman Date: 2013-01-31 17:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/716935fec613 Added tag jdk8-b75 for changeset c2e11e2ec4a3 ! .hgtags Changeset: 10619513f51a Author:lana Date: 2013-02-04 22:38 -0800 URL: http

hg: jdk8/tl/jdk: 2 new changesets

2013-02-04 Thread lana . steuck
Changeset: 6ba6353ab42c Author:katleman Date: 2013-01-31 17:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6ba6353ab42c Added tag jdk8-b75 for changeset 4a67fdb752b7 ! .hgtags Changeset: fd37f0846653 Author:lana Date: 2013-02-04 22:37 -0800 URL: http://hg.

hg: jdk8/tl/jaxws: Added tag jdk8-b75 for changeset 966bf9f3c41a

2013-02-04 Thread lana . steuck
Changeset: a63ef2391c20 Author:katleman Date: 2013-01-31 17:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/a63ef2391c20 Added tag jdk8-b75 for changeset 966bf9f3c41a ! .hgtags