On 02/02/2013 16:29, Alan Bateman wrote:
On 02/02/2013 14:39, John Zavgren wrote:
Greetings:
Please consider the following modification of our classes for handling
URLs.
http://cr.openjdk.java.net/~jzavgren/4880778/webrev.01/
This looks okay to me.
Yes, looks ok to me too.
For the URLStreamHandler setURL methods then an alternative to removing
the statement would be just adjust the wording, say replace "be able to
call the set method on a URL" to "be able to use this method to set the
values of the URL fields".
I think Alan's wording is probably best here.
There a subtlety I missed the first time I read the proposed wording,
'this method'. Overriding setURL in a concrete URLStreamHandler will
never be able to set the fields of a URL. So the wording is technically
correct.
Minor nit, but there are couple of alignment issues. In URL then the
arguments spill onto 2 or 3 lines so they can be re-aligned. In
URLStreamHandler it look slike the setURL method isn't quite lined up
with the other methods (pre-dates your proposed changes).
Agreed.
-Chris.
-Alan.
