hg: jdk7/tl/jdk: 2 new changesets

2010-10-18 Thread alan . bateman
Changeset: b79600ecf0e4 Author:alanb Date: 2010-10-18 10:29 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b79600ecf0e4 4837564: (bf) Please make DirectByteBuffer performance enhancements Reviewed-by: chegar ! src/share/classes/java/nio/Direct-X-Buffer.java.template ! src/sh

Re: IPv6 Nameservers in resolv.conf

2010-10-18 Thread Chris Hegarty
Hi Guenther, Before we can accept patches or changes from an external contributor you must sign the Contributor Agreement [1]. I looked at the list of contributors and cannot find you listed. I haven't looked at the patch yet, but I have looked at the testcase that's in CR 6991580. Have you

hg: jdk7/tl/jdk: 2 new changesets

2010-10-18 Thread sean . mullan
Changeset: 0f5bab573e01 Author:mullan Date: 2010-10-18 09:00 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0f5bab573e01 6988599: CertificateRevokedException specifies name of authority but interacts with authority instance Reviewed-by: vinnie ! src/share/classes/java/secur

Code Review 6992545: find bugs issues

2010-10-18 Thread Chris Hegarty
Alan, Michael, Clean up some issue found by findbugs; reference to mutable array being exposed, unused variables/imports. http://cr.openjdk.java.net/~chegar/6992545/webrev.00/webrev/ Thanks, -Chris.

Re: Code Review 6992545: find bugs issues

2010-10-18 Thread Alan Bateman
Chris Hegarty wrote: Alan, Michael, Clean up some issue found by findbugs; reference to mutable array being exposed, unused variables/imports. http://cr.openjdk.java.net/~chegar/6992545/webrev.00/webrev/ Thanks, -Chris. Looks okay to except I wonder about Headers.normalize - shouldn't that

Re: Code Review 6992545: find bugs issues

2010-10-18 Thread Chris Hegarty
On 18/10/2010 16:25, Alan Bateman wrote: Chris Hegarty wrote: Alan, Michael, Clean up some issue found by findbugs; reference to mutable array being exposed, unused variables/imports. http://cr.openjdk.java.net/~chegar/6992545/webrev.00/webrev/ Thanks, -Chris. Looks okay to except I wonder a

hg: jdk7/tl/jdk: 6992545: FindBugs scan - Malicious code vulnerability Warnings in com.sun.net.httpserver.HttpsParameters.*

2010-10-18 Thread chris . hegarty
Changeset: 5193b0c2baf0 Author:chegar Date: 2010-10-18 16:51 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5193b0c2baf0 6992545: FindBugs scan - Malicious code vulnerability Warnings in com.sun.net.httpserver.HttpsParameters.* Reviewed-by: alanb ! src/share/classes/com/sun

Re: Code Review 6992545: find bugs issues

2010-10-18 Thread Alan Bateman
Chris Hegarty wrote: : b[] is a char array and not a byte array, so we should be fine here. Thanks for the review. Sorry about that, I guess calling the char[] "b" tricked me into thinking it was a byte[]. -Alan.

hg: jdk7/tl/jdk: 6974104: TEST: sun/nio/ch/6645197.java should be fixed in 1.5.0u25b05 and jdk6 workspace

2010-10-18 Thread sean . coffey
Changeset: 426e5f2dbea3 Author:coffeys Date: 2010-10-18 18:04 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/426e5f2dbea3 6974104: TEST: sun/nio/ch/6645197.java should be fixed in 1.5.0u25b05 and jdk6 workspace Reviewed-by: alanb + test/java/nio/channels/Selector/TemporaryS

hg: jdk7/tl/langtools: 6991980: polymorphic signature calls don't share the same CP entries

2010-10-18 Thread maurizio . cimadamore
Changeset: 493ecc8111ba Author:mcimadamore Date: 2010-10-18 19:14 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/493ecc8111ba 6991980: polymorphic signature calls don't share the same CP entries Summary: wrong use of attr env in Infer.java prevents sharing of CP entries

hg: jdk7/tl/langtools: 6551367: javadoc throws ClassCastException when an @link tries to reference constructor.

2010-10-18 Thread sundararajan . a
Changeset: 5286a99de2e6 Author:sundar Date: 2010-10-19 11:47 +0530 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/5286a99de2e6 6551367: javadoc throws ClassCastException when an @link tries to reference constructor. Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/