On 18/10/2010 16:25, Alan Bateman wrote:
Chris Hegarty wrote:
Alan, Michael,

Clean up some issue found by findbugs; reference to mutable array
being exposed, unused variables/imports.

http://cr.openjdk.java.net/~chegar/6992545/webrev.00/webrev/

Thanks,
-Chris.
Looks okay to except I wonder about Headers.normalize - shouldn't that
be using a CharsetEncoder/Decoder as the existing code seems to be using
the default encoding.

b[] is a char array and not a byte array, so we should be fine here. Thanks for the review.

-Chris.


-Alan

Reply via email to