Code Review 6934054: java/net/Socket/FDClose.java return error in samevm

2010-03-11 Thread Christopher Hegarty -Sun Microsystems Ireland
Hi Alan, Michael, Another small test change! This test requires interruptible I/O to verify that the accept implementation does not impact on fd0. UseVMInterruptibleIO needs to be explicitly enabled since it is now disabled by default, see 6554406. Without interruptible I/O the thread executi

Re: Code Review 6934054: java/net/Socket/FDClose.java return error in samevm

2010-03-11 Thread Alan Bateman
Christopher Hegarty -Sun Microsystems Ireland wrote: Hi Alan, Michael, Another small test change! This test requires interruptible I/O to verify that the accept implementation does not impact on fd0. UseVMInterruptibleIO needs to be explicitly enabled since it is now disabled by default, see

Re: Code Review 6934054: java/net/Socket/FDClose.java return error in samevm

2010-03-11 Thread Christopher Hegarty -Sun Microsystems Ireland
Alan Bateman wrote: . I'm tempted to suggest that the best thing is to just hg rm the test as it's not very useful. If you want to keep it then the changes looks OK This had crossed my mind. If you agree then I think I will just remove it. -Chris. to me. One suggestion is to have ARea

Re: Code Review 6934054: java/net/Socket/FDClose.java return error in samevm

2010-03-11 Thread Alan Bateman
Christopher Hegarty -Sun Microsystems Ireland wrote: Alan Bateman wrote: . I'm tempted to suggest that the best thing is to just hg rm the test as it's not very useful. If you want to keep it then the changes looks OK This had crossed my mind. If you agree then I think I will just rem

hg: jdk7/tl/jdk: 6934054: java/net/Socket/FDClose.java return error in samevm

2010-03-11 Thread christopher . hegarty
Changeset: 07e1c5a90c6a Author:chegar Date: 2010-03-11 16:17 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/07e1c5a90c6a 6934054: java/net/Socket/FDClose.java return error in samevm Summary: test is no longer useful Reviewed-by: alanb ! test/ProblemList.txt - test/java/net/S

Re: Code Review: 6223635 Code hangs at connect call even when Timeout is specified when using a socks proxy

2010-03-11 Thread Michael McMahon
Christopher Hegarty -Sun Microsystems Ireland wrote: Hi All, This patch fixes a problem where the socks proxy implementation does not honor the timeout specified in Socket.connect(SocketAddress, timeout). In fact, it uses the read timeout set with setSoTimeout since the socks implementation o

Re: Code Review: 6223635 Code hangs at connect call even when Timeout is specified when using a socks proxy

2010-03-11 Thread Christopher Hegarty -Sun Microsystems Ireland
Michael McMahon wrote: Christopher Hegarty -Sun Microsystems Ireland wrote: Hi All, This patch fixes a problem where the socks proxy implementation does not honor the timeout specified in Socket.connect(SocketAddress, timeout). In fact, it uses the read timeout set with setSoTimeout since th

Re: Code Review: 6223635 Code hangs at connect call even when Timeout is specified when using a socks proxy

2010-03-11 Thread Michael McMahon
Christopher Hegarty -Sun Microsystems Ireland wrote: Michael McMahon wrote: Christopher Hegarty -Sun Microsystems Ireland wrote: Hi All, This patch fixes a problem where the socks proxy implementation does not honor the timeout specified in Socket.connect(SocketAddress, timeout). In fact, it

hg: jdk7/tl/jdk: 6933629: java/net/HttpURLConnection/HttpResponseCode.java fails if run in samevm mode

2010-03-11 Thread christopher . hegarty
Changeset: c342735a3e58 Author:chegar Date: 2010-03-11 17:37 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c342735a3e58 6933629: java/net/HttpURLConnection/HttpResponseCode.java fails if run in samevm mode Reviewed-by: alanb ! test/ProblemList.txt ! test/java/net/CookieHan

hg: jdk7/tl/jdk: 6223635: Code hangs at connect call even when Timeout is specified when using a socks proxy

2010-03-11 Thread christopher . hegarty
Changeset: c6f8c58ed51a Author:chegar Date: 2010-03-11 17:50 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c6f8c58ed51a 6223635: Code hangs at connect call even when Timeout is specified when using a socks proxy Reviewed-by: michaelm, chegar Contributed-by: damjan@gmail

hg: jdk7/tl/jdk: 6929479: Add a system property sun.zip.disableMemoryMapping to disable mmap use in ZipFile

2010-03-11 Thread xueming . shen
Changeset: ee385b4e2ffb Author:sherman Date: 2010-03-11 14:06 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ee385b4e2ffb 6929479: Add a system property sun.zip.disableMemoryMapping to disable mmap use in ZipFile Summary: system property sun.zip.disableMemoryMapping to disab