Re: [Fwd: [PATCH]: Portability fixes]

2009-02-02 Thread Martin Buchholz
On Mon, Feb 2, 2009 at 05:42, Christopher Hegarty - Sun Microsystems Ireland wrote: > +static int isAsciiSpace(char c) { > + return (((c) == '\t') || ((c) == '\r') || ((c) == '\b') || > + ((c) == '\n') || ((c) == ' ') ); > +} > + A very minor comment - the parens around (c) are a very

hg: jdk7/tl/jdk: 6791927: Wrong Locale in HttpCookie::expiryDate2DeltaSeconds

2009-02-02 Thread jean-christophe . collet
Changeset: 6c5d04d1eff4 Author:jccollet Date: 2009-02-02 16:50 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6c5d04d1eff4 6791927: Wrong Locale in HttpCookie::expiryDate2DeltaSeconds Summary: Force Locale.US when parsing the cookie expiration date. Reviewed-by: chegar ! src

Re: [Fwd: [PATCH]: Portability fixes]

2009-02-02 Thread Christopher Hegarty - Sun Microsystems
Martin Buchholz wrote: On Mon, Feb 2, 2009 at 05:42, Christopher Hegarty - Sun Microsystems Ireland wrote: +static int isAsciiSpace(char c) { + return (((c) == '\t') || ((c) == '\r') || ((c) == '\b') || + ((c) == '\n') || ((c) == ' ') ); +} + A very minor comment - the parens aroun

Re: [Fwd: [PATCH]: Portability fixes]

2009-02-02 Thread Alan Bateman
Christopher Hegarty - Sun Microsystems Ireland wrote: Hi Alan, Christos, I've looked at the changes that Christos suggested and also how Martin fixed UNIXProcess_md. Here is what I believe the final change should look like. Comments: 1) "3. last is possibly uninitialized." We have already

Re: [Fwd: [PATCH]: Portability fixes]

2009-02-02 Thread Christopher Hegarty - Sun Microsystems Ireland
Hi Alan, Christos, I've looked at the changes that Christos suggested and also how Martin fixed UNIXProcess_md. Here is what I believe the final change should look like. Comments: 1) "3. last is possibly uninitialized." We have already fixed this in a previous changeset, see [1] 2) I made

hg: jdk7/tl/jdk: 2 new changesets

2009-02-02 Thread weijun . wang
Changeset: dbb82636df41 Author:weijun Date: 2009-02-03 09:38 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dbb82636df41 6552334: Enable DNS in Kerberos by default Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/Config.java ! src/share/classes/sun/security/krb5/K