On 19/11/2011 19:44, Alan Bateman wrote:
> On 18/11/2011 10:57, Chris Hegarty wrote:
>> Hi Kris,
>>
>> I think this change should be fine, but I would like Alan to comment also.
>>
> I looked at it in more detail and I think it should okay. Will you
> sponsor it? My only comment on the change is th
On 18/11/2011 10:57, Chris Hegarty wrote:
> Hi Kris,
>
> I think this change should be fine, but I would like Alan to comment also.
>
I looked at it in more detail and I think it should okay. Will you
sponsor it? My only comment on the change is the catching of
SocketException causes a RuntimeExcep
On 18/11/2011 10:57, Chris Hegarty wrote:
> Hi Kris,
>
> I think this change should be fine, but I would like Alan to comment also.
>
I'm not around this week but will look at it next week. One initial
comment is that the need to use the socket adapter went away in jdk7.
Newer code using SocketChan
Hi Kris,
I think this change should be fine, but I would like Alan to comment also.
Thanks,
-Chris.
On 11/18/11 10:44 AM, Chris Hegarty wrote:
>
>
> Original Message
> Subject: Re: Suppress creation of SocksSocketImpl in SocketAdaptor's
> constructor
>
Original Message
Subject: Re: Suppress creation of SocksSocketImpl in SocketAdaptor's
constructor
Date: Fri, 18 Nov 2011 16:38:28 +0800
From: Krystal Mok
To: 撒迦
CC: jdk8-...@openjdk.java.net
Oops, looks like my company email stripped the attachment.
Here's that p
Kris,
This issue would be more appropriate on the net-dev or nio-dev mailing
lists. So, I'll cross post it and bcc off jdk8-dev.
Thanks,
-Chris.
On 11/18/11 08:22 AM, 撒迦 wrote:
> Hi all,
>
> I'd like to propose the following change to JDK's sun.nio.ch.SocketAdaptor:
>
> In OpenJDK 6, 7 and 8,
