On 19/11/2011 19:44, Alan Bateman wrote: > On 18/11/2011 10:57, Chris Hegarty wrote: >> Hi Kris, >> >> I think this change should be fine, but I would like Alan to comment also. >> > I looked at it in more detail and I think it should okay. Will you > sponsor it? My only comment on the change is the catching of > SocketException causes a RuntimeException to be thrown but that is > inconsistent with other areas of this code where AssertionError or > InternalError is thrown.
Yes, I can sponsor this change. And yes, I agree InternalError would be better. -Chris. > > -Alan
