Re: RFR 8216417: cleanup of IPv6 scope-id handling

2019-06-12 Thread Chris Hegarty
Michael, On 11/06/2019 18:14, Michael McMahon wrote: ... Updated webrev: http://cr.openjdk.java.net/~michaelm/8216417/webrev.4/ This looks very good. -Chris.

Re: RFR 8216417: cleanup of IPv6 scope-id handling

2019-06-11 Thread Alan Bateman
On 11/06/2019 18:14, Michael McMahon wrote: Hi Alan I've made the suggested changes. I need to confirm with Pavel what the background was for the Linux kernel check. For now, it is still there in the test. Maybe, that could be removed as part of another change later, if that turns out to be p

Re: RFR 8216417: cleanup of IPv6 scope-id handling

2019-06-11 Thread Michael McMahon
Hi Alan I've made the suggested changes. I need to confirm with Pavel what the background was for the Linux kernel check. For now, it is still there in the test. Maybe, that could be removed as part of another change later, if that turns out to be possible. Updated webrev: http://cr.openjdk.

Re: RFR 8216417: cleanup of IPv6 scope-id handling

2019-06-11 Thread Chris Hegarty
Michael, > On 11 Jun 2019, at 14:55, Michael McMahon > wrote: > > Hi Chris > > DatagramSocket has its own copies of the same fields and it stores > the values supplied by the caller (rather than the scopified version), > which are returned by getRemoteSocketAddress() and getInetAddress(). > A

Re: RFR 8216417: cleanup of IPv6 scope-id handling

2019-06-11 Thread Michael McMahon
Hi Chris DatagramSocket has its own copies of the same fields and it stores the values supplied by the caller (rather than the scopified version), which are returned by getRemoteSocketAddress() and getInetAddress(). Michael. On 11/06/2019, 14:19, Chris Hegarty wrote: Michael, On 11 Jun 2019,

Re: RFR 8216417: cleanup of IPv6 scope-id handling

2019-06-11 Thread Chris Hegarty
Michael, > On 11 Jun 2019, at 12:11, Michael McMahon > wrote: > > Thanks for the review Alan. > I've made the changes suggested by you and Daniel > and added a test to Scoping.java for checking the connected IP address. > > http://cr.openjdk.java.net/~michaelm/8216417/webrev.3/index.html Look

Re: RFR 8216417: cleanup of IPv6 scope-id handling

2019-06-11 Thread Alan Bateman
On 11/06/2019 12:11, Michael McMahon wrote: Thanks for the review Alan. I've made the changes suggested by you and Daniel and added a test to Scoping.java for checking the connected IP address. http://cr.openjdk.java.net/~michaelm/8216417/webrev.3/index.html One suggestion for the AbstractPlainS

Re: RFR 8216417: cleanup of IPv6 scope-id handling

2019-06-11 Thread Michael McMahon
Thanks for the review Alan. I've made the changes suggested by you and Daniel and added a test to Scoping.java for checking the connected IP address. http://cr.openjdk.java.net/~michaelm/8216417/webrev.3/index.html - Michael On 10/06/2019, 16:49, Alan Bateman wrote: On 10/06/2019 15:18, Micha

Re: RFR 8216417: cleanup of IPv6 scope-id handling

2019-06-11 Thread Michael McMahon
Good point Daniel. Thanks for the review. - Michael. On 10/06/2019, 19:48, Daniel Fuchs wrote: Hi Michael, AbstractPlainDatagramSocketImpl.java: in `send` maybe the packet should only be recreated if the address is different. best regards, -- daniel On 10/06/2019 15:18, Michael McMahon wro

Re: RFR 8216417: cleanup of IPv6 scope-id handling

2019-06-10 Thread Daniel Fuchs
Hi Michael, AbstractPlainDatagramSocketImpl.java: in `send` maybe the packet should only be recreated if the address is different. best regards, -- daniel On 10/06/2019 15:18, Michael McMahon wrote: Hi, Could I get the following change to net/nio reviewed please? It is a general cleanup of

Re: RFR 8216417: cleanup of IPv6 scope-id handling

2019-06-10 Thread Alan Bateman
On 10/06/2019 15:18, Michael McMahon wrote: Hi, Could I get the following change to net/nio reviewed please? It is a general cleanup of IPv6 scope_id handling which removes a lot of native code trickery (mostly in Linux) and simplifies the handling of scope_ids such that: a) when binding/con