On 11/06/2019 18:14, Michael McMahon wrote:
Hi Alan
I've made the suggested changes. I need to confirm with Pavel what the
background
was for the Linux kernel check. For now, it is still there in the
test. Maybe, that could
be removed as part of another change later, if that turns out to be
possible.
Okay with me.. I tracked down the November thread on net-dev where this
came up but I couldn't find anything that fully explained it.
Updated webrev: http://cr.openjdk.java.net/~michaelm/8216417/webrev.4/
I think this looks good.
Just a few minor comments on the Scoping.java test
- both DatagramChannel and DatagramSocket implement AutoCloseable so the
test can using try-with-resources.
- I suspect socketTest leaks a connection as it establishes a connection
but doesn't accept/close it. Probably not a concern as the test is /othervm.
I don't need another webrev on those points.
-Alan
