> On 20 Oct 2016, at 13:47, Pavel Rappo wrote:
>
> Hello,
>
> Could you please review the following change for [1]?
>
> http://cr.openjdk.java.net/~prappo/8168405/webrev/
Thank you Pavel, this looks good.
-Chris.
> This change addresses some code paths in the native networking code for
>
Hi Pavel,
> > On 20 Oct 2016, at 14:03, Langer, Christoph
> wrote:
> >
> > Hi Pavel,
> >
> > overall this looks good. I've got a few minor remarks:
> >
> > 1. What about using the macro CHECK_NULL_RETURN in
> NetworkInterface_winXP.c?
> >
> > 2. in Java_java_net_TwoStacksPlainDatagramSocketImpl_p
> On 20 Oct 2016, at 14:03, Langer, Christoph wrote:
>
> Hi Pavel,
>
> overall this looks good. I've got a few minor remarks:
>
> 1. What about using the macro CHECK_NULL_RETURN in NetworkInterface_winXP.c?
>
> 2. in Java_java_net_TwoStacksPlainDatagramSocketImpl_peekData:
>
> You could move
Hi Pavel,
overall this looks good. I've got a few minor remarks:
1. What about using the macro CHECK_NULL_RETURN in NetworkInterface_winXP.c?
2. in Java_java_net_TwoStacksPlainDatagramSocketImpl_peekData:
You could move
1178 /* make sure receive() picks up the right fd */
1179 (*env)->S
