On Thu, 10 Sep 2020 11:43:51 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my doc-only fix for JDK-8251496 - ‘Fix doclint
>> warnings in jdk.net.httpserver’ ?
>>
>> This fix addresses the warnings generated by `javadoc -Xdoclint` due to
>> missing/incomplete API docu
On Thu, 10 Sep 2020 11:43:51 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my doc-only fix for JDK-8251496 - ‘Fix doclint
>> warnings in jdk.net.httpserver’ ?
>>
>> This fix addresses the warnings generated by `javadoc -Xdoclint` due to
>> missing/incomplete API docu
On Thu, 10 Sep 2020 11:43:51 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my doc-only fix for JDK-8251496 - ‘Fix doclint
>> warnings in jdk.net.httpserver’ ?
>>
>> This fix addresses the warnings generated by `javadoc -Xdoclint` due to
>> missing/incomplete API docu
> Hi,
>
> Could someone please review my doc-only fix for JDK-8251496 - ‘Fix doclint
> warnings in jdk.net.httpserver’ ?
>
> This fix addresses the warnings generated by `javadoc -Xdoclint` due to
> missing/incomplete API documentation for
> several classes within `jdk.net.httpserver`.
> Kind r
On Thu, 10 Sep 2020 08:51:33 GMT, Daniel Fuchs wrote:
>> src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpExchange.java
>> line 192:
>>
>>> 190: *no response body may be written.
>>> 191: * @throws IOException An IOException will be thrown if an error
>>> occurs du
On Wed, 9 Sep 2020 13:20:45 GMT, Roger Riggs wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8251496: reworded abstract cstr comments; removed unnecessary punctuation
>
> src/jdk.httpserver/share/classes/com/s
On Wed, 9 Sep 2020 09:24:24 GMT, Chris Hegarty wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental
>> webrev excludes the unrelated changes brought in by the merge/rebase. The
>> pull request contains two additional comm
On Wed, 9 Sep 2020 08:50:38 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my doc-only fix for JDK-8251496 - ‘Fix doclint
>> warnings in jdk.net.httpserver’ ?
>>
>> This fix addresses the warnings generated by `javadoc -Xdoclint` due to
>> missing/incomplete API docum
On Wed, 9 Sep 2020 12:14:28 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my doc-only fix for JDK-8251496 - ‘Fix doclint
>> warnings in jdk.net.httpserver’ ?
>>
>> This fix addresses the warnings generated by `javadoc -Xdoclint` due to
>> missing/incomplete API docum
On Wed, 9 Sep 2020 13:29:05 GMT, Roger Riggs wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8251496: reworded abstract cstr comments; removed unnecessary punctuation
>
> The @param and @return lines that star
On Wed, 9 Sep 2020 12:14:28 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my doc-only fix for JDK-8251496 - ‘Fix doclint
>> warnings in jdk.net.httpserver’ ?
>>
>> This fix addresses the warnings generated by `javadoc -Xdoclint` due to
>> missing/incomplete API docum
On Wed, 9 Sep 2020 12:16:44 GMT, Patrick Concannon
wrote:
>> src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpsParameters.java
>> line 30:
>>
>>> 28: import java.net.InetSocketAddress;
>>> 29:
>>> 30: //BEGIN_TIGER_EXCLUDE
>>
>> I don't have the context here - but if we're removing
On Tue, 8 Sep 2020 16:34:12 GMT, Daniel Fuchs wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8251496: reworded abstract cstr comments; removed unnecessary punctuation
>
> src/jdk.httpserver/share/classes/com/
> Hi,
>
> Could someone please review my doc-only fix for JDK-8251496 - ‘Fix doclint
> warnings in jdk.net.httpserver’ ?
>
> This fix addresses the warnings generated by `javadoc -Xdoclint` due to
> missing/incomplete API documentation for
> several classes within `jdk.net.httpserver`.
> Kind r
> Hi,
>
> Could someone please review my doc-only fix for JDK-8251496 - ‘Fix doclint
> warnings in jdk.net.httpserver’ ?
>
> This fix addresses the warnings generated by `javadoc -Xdoclint` due to
> missing/incomplete API documentation for
> several classes within `jdk.net.httpserver`.
> CSR: h
On 08/09/2020 21:02, Roger Riggs wrote:
And will need to be updated as a new PR under git.
PR: https://git.openjdk.java.net/jdk/pull/81
best regards,
-- daniel
Hi Patrick,
Usually, the @param and @returns text does not edit a period (unless it
is a complete sentence).
The indentation of the new comment blocks is in a few places off.
I.e.
+++ b/src/jdk.httpserver/share/classes/com/sun/net/httpserver/Headers.java
Mon Aug 31 16:57:06 2020 +0100
@
On Tue, 8 Sep 2020 16:22:15 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my doc-only fix for JDK-8251496 - ‘Fix doclint
> warnings in jdk.net.httpserver’ ?
>
> This fix addresses the warnings generated by `javadoc -Xdoclint` due to
> missing/incomplete API documentatio
18 matches
Mail list logo
