On Wed, 9 Sep 2020 09:24:24 GMT, Chris Hegarty <che...@openjdk.org> wrote:
>> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental >> webrev excludes the unrelated changes brought in by the merge/rebase. The >> pull request contains two additional commits >> since the last revision: >> - Merge branch 'master' into JDK-8251496 >> - 8251496: Fix doclint warnings in jdk.net.httpserver > > src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpExchange.java > line 192: > >> 190: * no response body may be written. >> 191: * @throws IOException An IOException will be thrown if an error >> occurs during >> 192: * the sending of response headers, or if headers have >> already been sent. > >> "or if headers have already been sent." > > Maybe I missed it, but is there a test to assert this? It is not obvious to > me why this is being added now. +1 for adding a small test to verify that `IOException` is thrown if `sendResponseHeaders()` is called twice (unless that test already exists). I assume Patrick figured that out by reading the corresponding code? ------------- PR: https://git.openjdk.java.net/jdk/pull/81
