On Thu, 4 Mar 2021 05:16:02 GMT, Xue-Lei Andrew Fan wrote:
>> Vyom Tewari has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added a comment that host has bees set previously
>
> Thank you. I have no more comment.
Shouldn't there be a regr
On Thu, 4 Mar 2021 04:02:03 GMT, Vyom Tewari wrote:
>> HttpsURLConnection, works with SunJSSE provider but does not work with other
>> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as
>> follows
>>
>> s = (SSLSocket)serverSocket;
>>if (s instanceof SSLSocketImpl)
On Thu, 4 Mar 2021 00:27:52 GMT, Xue-Lei Andrew Fan wrote:
>> Vyom Tewari has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - resolve jcheck issue.
>> - put if block which will prevent host being set twice in case of
>> SSLSocketImpl
>
>
On Wed, 3 Mar 2021 15:20:29 GMT, Vyom Tewari wrote:
>> Vyom, can you provide, or point to a test that exercises the code paths that
>> have been changed? And also some new test that would fail before the fix and
>> pass after?
>>
>> best regards,
>>
>> -- daniel
>
>> Vyom, can you provide, o
> HttpsURLConnection, works with SunJSSE provider but does not work with other
> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as
> follows
>
> s = (SSLSocket)serverSocket;
>if (s instanceof SSLSocketImpl) {
> ((SSLSocketImpl)s).setHost(host);
>}
>
On Wed, 3 Mar 2021 17:56:02 GMT, Vyom Tewari wrote:
>> HttpsURLConnection, works with SunJSSE provider but does not work with other
>> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as
>> follows
>>
>> s = (SSLSocket)serverSocket;
>>if (s instanceof SSLSocketImpl)
On Wed, 3 Mar 2021 16:16:48 GMT, Xue-Lei Andrew Fan wrote:
>> Vyom Tewari has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> reverted the overly deleted else block
>
> src/java.base/share/classes/sun/net/www/protocol/https/HttpsClient.java
> HttpsURLConnection, works with SunJSSE provider but does not work with other
> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as
> follows
>
> s = (SSLSocket)serverSocket;
>if (s instanceof SSLSocketImpl) {
> ((SSLSocketImpl)s).setHost(host);
>}
>
On Wed, 3 Mar 2021 15:10:54 GMT, Vyom Tewari wrote:
>> HttpsURLConnection, works with SunJSSE provider but does not work with other
>> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as
>> follows
>>
>> s = (SSLSocket)serverSocket;
>>if (s instanceof SSLSocketImpl)
On Wed, 3 Mar 2021 10:09:34 GMT, Daniel Fuchs wrote:
> Vyom, can you provide, or point to a test that exercises the code paths that
> have been changed? And also some new test that would fail before the fix and
> pass after?
>
> best regards,
>
> -- daniel
Hi Daniel,
there are multiple test
> HttpsURLConnection, works with SunJSSE provider but does not work with other
> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as
> follows
>
> s = (SSLSocket)serverSocket;
>if (s instanceof SSLSocketImpl) {
> ((SSLSocketImpl)s).setHost(host);
>}
>
On Wed, 3 Mar 2021 11:36:19 GMT, Vyom Tewari wrote:
>> src/java.base/share/classes/sun/net/www/protocol/https/HttpsClient.java line
>> 454:
>>
>>> 452: s = (SSLSocket)factory.createSocket(serverSocket,
>>> 453: host, po
On Wed, 3 Mar 2021 10:05:24 GMT, Daniel Fuchs wrote:
>> Vyom Tewari has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> used List.of instead of Collections.singletonList
>
> src/java.base/share/classes/sun/net/www/protocol/https/HttpsClient.
On Wed, 3 Mar 2021 04:27:15 GMT, Vyom Tewari wrote:
>> HttpsURLConnection, works with SunJSSE provider but does not work with other
>> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as
>> follows
>>
>> s = (SSLSocket)serverSocket;
>>if (s instanceof SSLSocketImpl)
On Wed, 3 Mar 2021 08:51:13 GMT, Vyom Tewari wrote:
>>> > HttpsURLConnection, works with SunJSSE provider but does not work with
>>> > other JSSE provider. In case of SunJSSE , HttpsURLConnection set the host
>>> > name as follows
>>> > s = (SSLSocket)serverSocket;
>>> > if (s instanceof SSLSoc
> HttpsURLConnection, works with SunJSSE provider but does not work with other
> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as
> follows
>
> s = (SSLSocket)serverSocket;
>if (s instanceof SSLSocketImpl) {
> ((SSLSocketImpl)s).setHost(host);
>}
>
On Wed, 3 Mar 2021 05:01:13 GMT, Vyom Tewari wrote:
>>> HttpsURLConnection, works with SunJSSE provider but does not work with
>>> other JSSE provider. In case of SunJSSE , HttpsURLConnection set the host
>>> name as follows
>>>
>>> s = (SSLSocket)serverSocket;
>>> if (s instanceof SSLSocketIm
On Wed, 3 Mar 2021 04:38:47 GMT, Xue-Lei Andrew Fan wrote:
> > HttpsURLConnection, works with SunJSSE provider but does not work with
> > other JSSE provider. In case of SunJSSE , HttpsURLConnection set the host
> > name as follows
> > s = (SSLSocket)serverSocket;
> > if (s instanceof SSLSocket
On Tue, 16 Feb 2021 07:50:05 GMT, Vyom Tewari wrote:
> HttpsURLConnection, works with SunJSSE provider but does not work with other
> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as
> follows
>
> s = (SSLSocket)serverSocket;
> if (s instanceof SSLSocketImpl) {
> ((S
On Tue, 2 Mar 2021 20:17:25 GMT, Xue-Lei Andrew Fan wrote:
>> Vyom Tewari has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> used List.of instead of Collections.singletonList
>
> src/java.base/share/classes/sun/net/www/protocol/https/HttpsC
> HttpsURLConnection, works with SunJSSE provider but does not work with other
> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as
> follows
>
> s = (SSLSocket)serverSocket;
>if (s instanceof SSLSocketImpl) {
> ((SSLSocketImpl)s).setHost(host);
>}
>
On Tue, 16 Feb 2021 07:50:05 GMT, Vyom Tewari wrote:
> HttpsURLConnection, works with SunJSSE provider but does not work with other
> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as
> follows
>
> s = (SSLSocket)serverSocket;
>if (s instanceof SSLSocketImpl) {
>
On Tue, 2 Mar 2021 15:56:35 GMT, Daniel Fuchs wrote:
>> i ran tests, it looks
>> clean(https://github.com/vyommani/jdk/actions/runs/612949667)
>
> As far as I know this is only tier1 - so none of the network tests have been
> run.
I ran tier1 & tier2 tests locally on my linux vm, it was clear.
On Tue, 2 Mar 2021 15:34:56 GMT, Vyom Tewari wrote:
>> Did you try to run the httpclient tests? They make use of the httpserver -
>> so they can also serve to test it - somewhat.
>> More generally - please run jdk_net/tier2 tests.
>
> i ran tests, it looks
> clean(https://github.com/vyommani/jd
On Tue, 2 Mar 2021 15:03:47 GMT, Daniel Fuchs wrote:
>> May be i am not sure, we may need this code change to review by security
>> expert. I am setting "SNIHostName" only if "isDefaultHostnameVerifier" is
>> true(If the HNV is the default from HttpsURLConnection) so there should not
>> be pro
On Tue, 2 Mar 2021 14:39:43 GMT, Vyom Tewari wrote:
>> src/java.base/share/classes/sun/net/www/protocol/https/HttpsClient.java line
>> 569:
>>
>>> 567: SSLParameters paramaters = s.getSSLParameters();
>>> 568:
>>> paramaters.setEndpointIdentificationAlgo
On Tue, 2 Mar 2021 12:43:27 GMT, Daniel Fuchs wrote:
>> HttpsURLConnection, works with SunJSSE provider but does not work with other
>> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as
>> follows
>>
>> s = (SSLSocket)serverSocket;
>>if (s instanceof SSLSocketImpl
On Tue, 16 Feb 2021 07:50:05 GMT, Vyom Tewari wrote:
> HttpsURLConnection, works with SunJSSE provider but does not work with other
> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as
> follows
>
> s = (SSLSocket)serverSocket;
>if (s instanceof SSLSocketImpl) {
>
28 matches
Mail list logo
