Re: RFR: 8263905: Remove finalize methods for SocketInput/OutputStream [v2]

2021-03-23 Thread Kim Barrett
On Mon, 22 Mar 2021 16:37:28 GMT, Mandy Chung wrote: >> Kim Barrett has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains two additional >> commits si

Re: RFR: 8263905: Remove finalize methods for SocketInput/OutputStream [v2]

2021-03-23 Thread Kim Barrett
> Please review this change to java.net.SocketInputStream and > java.net.SocketOutputStream, removing their "finalize" methods. These > methods are empty. Their purpose is to override and suppress the finalize > methods of their superclasses (FileInputStream and FileOutputStream, > respectively).

Re: RFR: 8263905: Remove finalize methods for SocketInput/OutputStream

2021-03-22 Thread Mandy Chung
On Mon, 22 Mar 2021 06:02:37 GMT, Kim Barrett wrote: > Please review this change to java.net.SocketInputStream and > java.net.SocketOutputStream, removing their "finalize" methods. These > methods are empty. Their purpose is to override and suppress the finalize > methods of their superclasses

Re: RFR: 8263905: Remove finalize methods for SocketInput/OutputStream

2021-03-22 Thread Daniel Fuchs
On Mon, 22 Mar 2021 06:02:37 GMT, Kim Barrett wrote: > Please review this change to java.net.SocketInputStream and > java.net.SocketOutputStream, removing their "finalize" methods. These > methods are empty. Their purpose is to override and suppress the finalize > methods of their superclasses

Re: RFR: 8263905: Remove finalize methods for SocketInput/OutputStream

2021-03-22 Thread Vyom Tewari
On Mon, 22 Mar 2021 06:02:37 GMT, Kim Barrett wrote: > Please review this change to java.net.SocketInputStream and > java.net.SocketOutputStream, removing their "finalize" methods. These > methods are empty. Their purpose is to override and suppress the finalize > methods of their superclasses

Re: RFR: 8263905: Remove finalize methods for SocketInput/OutputStream

2021-03-22 Thread Alan Bateman
On Mon, 22 Mar 2021 06:02:37 GMT, Kim Barrett wrote: > Please review this change to java.net.SocketInputStream and > java.net.SocketOutputStream, removing their "finalize" methods. These > methods are empty. Their purpose is to override and suppress the finalize > methods of their superclasses