> Please review this change to java.net.SocketInputStream and > java.net.SocketOutputStream, removing their "finalize" methods. These > methods are empty. Their purpose is to override and suppress the finalize > methods of their superclasses (FileInputStream and FileOutputStream, > respectively). But those classes had their finalize methods removed by > JDK-8192939 in JDK 12.
Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into sockstrm_nofinalize - remove finalize methods ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/3111/files - new: https://git.openjdk.java.net/jdk/pull/3111/files/e2db6df2..eaa05a5a Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3111&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3111&range=00-01 Stats: 2820 lines in 189 files changed: 1475 ins; 694 del; 651 mod Patch: https://git.openjdk.java.net/jdk/pull/3111.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3111/head:pull/3111 PR: https://git.openjdk.java.net/jdk/pull/3111
