On Tue, 9 Mar 2021 19:56:25 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.net`
>> and `java.nio` packages to make use of the `instanceof` pattern variable?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the
On Tue, 9 Mar 2021 20:52:19 GMT, Mark Sheppard wrote:
>> The disadvantage is that it would add another level of braces.
>
> maybe ... I find it would provide an easier flow to code ... an "easy on the
> eye" call flow linkage - the variable is declared and then used instead
> of the disc
On Tue, 9 Mar 2021 19:56:25 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.net`
>> and `java.nio` packages to make use of the `instanceof` pattern variable?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the
On Tue, 9 Mar 2021 20:26:19 GMT, Daniel Fuchs wrote:
>> src/java.base/share/classes/java/net/NetMulticastSocket.java line 219:
>>
>>> 217: if (addr == null)
>>> 218: addr = new InetSocketAddress(0);
>>> 219: if (!(addr instanceof InetSocketAddress epoint))
>>
>> in t
On Tue, 9 Mar 2021 19:56:25 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.net`
>> and `java.nio` packages to make use of the `instanceof` pattern variable?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the
On Tue, 9 Mar 2021 20:07:14 GMT, Mark Sheppard wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8263233: Refactored equals method further
>
> src/java.base/share/classes/java/net/NetMulticastSocket.java line 21
On Tue, 9 Mar 2021 18:22:17 GMT, Chris Hegarty wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8263233: Refactored equals method further
>
> src/java.base/share/classes/java/net/InterfaceAddress.java line 108:
On Tue, 9 Mar 2021 19:56:25 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.net`
>> and `java.nio` packages to make use of the `instanceof` pattern variable?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the
> Hi,
>
> Could someone please review my code for updating the code in the `java.net`
> and `java.nio` packages to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request incrementally with one
additional commit since the last r
On Tue, 9 Mar 2021 17:59:27 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.net`
>> and `java.nio` packages to make use of the `instanceof` pattern variable?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the
On Tue, 9 Mar 2021 13:01:10 GMT, Michael McMahon wrote:
>> src/java.base/share/classes/java/net/InterfaceAddress.java line 107:
>>
>>> 105:
>>> 106: if (Objects.equals(address, cmp.address) &&
>>> 107: Objects.equals(broadcast, cmp.broadcast) &&
>>
>> This could be
On Tue, 9 Mar 2021 12:44:10 GMT, Alan Bateman wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8263233: Small refactor of equals method in java/net/InterfaceAddress;
>> removed superfluous whitespace in java/n
On Tue, 9 Mar 2021 17:59:27 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.net`
>> and `java.nio` packages to make use of the `instanceof` pattern variable?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the
> Hi,
>
> Could someone please review my code for updating the code in the `java.net`
> and `java.nio` packages to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request incrementally with one
additional commit since the last r
On Tue, 9 Mar 2021 12:32:38 GMT, Chris Hegarty wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.net`
>> and `java.nio` packages to make use of the `instanceof` pattern variable?
>>
>> Kind regards,
>> Patrick
>
> src/java.base/share/classes/java/net/In
On Tue, 9 Mar 2021 11:07:07 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.net`
> and `java.nio` packages to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
src/java.base/share/classes/java/net/Inet6Ad
On Tue, 9 Mar 2021 11:07:07 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.net`
> and `java.nio` packages to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
src/java.base/share/classes/java/net/Interfa
On Tue, 9 Mar 2021 11:07:07 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.net`
> and `java.nio` packages to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
LGTM.
-
Marked as reviewed by
18 matches
Mail list logo
