On Mon, 7 Sep 2020 13:48:17 GMT, Jaikiran Pai wrote:
>> Hi Jaikiran,
>>
>> I'll sponsor this for you when it is ready to integrate but I'd like to send
>> it to our test system first.
>>
>> best regards,
>> -- daniel
>
> Thank you everyone for the reviews and thank you Daniel for sponsoring. I
On Mon, 7 Sep 2020 12:41:49 GMT, Daniel Fuchs wrote:
>> I think this version looks much better. A few nits with naming/style but not
>> worth spending time on.
>
> Hi Jaikiran,
>
> I'll sponsor this for you when it is ready to integrate but I'd like to send
> it to our test system first.
>
>
On Mon, 7 Sep 2020 12:35:50 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use new TestNG Assert#assertThrows API
>
> I think this version looks much better. A few nits with naming/style but not
On Mon, 7 Sep 2020 11:47:36 GMT, Jaikiran Pai wrote:
>> Can I please get a review and a sponsor for a fix for the issue reported at
>> https://bugs.openjdk.java.net/browse/JDK-8252767?
>> As noted in that issue, the `sun.net.www.URLConnection#setRequestProperty`
>> is throwing a `IllegalAccessEr
On Mon, 7 Sep 2020 11:47:36 GMT, Jaikiran Pai wrote:
>> Can I please get a review and a sponsor for a fix for the issue reported at
>> https://bugs.openjdk.java.net/browse/JDK-8252767?
>> As noted in that issue, the `sun.net.www.URLConnection#setRequestProperty`
>> is throwing a `IllegalAccessEr
On Mon, 7 Sep 2020 11:24:18 GMT, Chris Hegarty wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Convert to TestNG test case
>
> test/jdk/java/net/URLConnection/RequestProperties.java line 90:
>
>> 88: try {
> Can I please get a review and a sponsor for a fix for the issue reported at
> https://bugs.openjdk.java.net/browse/JDK-8252767?
> As noted in that issue, the `sun.net.www.URLConnection#setRequestProperty` is
> throwing a `IllegalAccessError` instead
> of a `IllegalStateException`. The commit her
On Mon, 7 Sep 2020 11:04:35 GMT, Jaikiran Pai wrote:
>> Can I please get a review and a sponsor for a fix for the issue reported at
>> https://bugs.openjdk.java.net/browse/JDK-8252767?
>> As noted in that issue, the `sun.net.www.URLConnection#setRequestProperty`
>> is throwing a `IllegalAccessEr
On Mon, 7 Sep 2020 11:04:35 GMT, Jaikiran Pai wrote:
>> Can I please get a review and a sponsor for a fix for the issue reported at
>> https://bugs.openjdk.java.net/browse/JDK-8252767?
>> As noted in that issue, the `sun.net.www.URLConnection#setRequestProperty`
>> is throwing a `IllegalAccessEr
On Mon, 7 Sep 2020 09:37:23 GMT, Chris Hegarty wrote:
> @jaikiran No need to be sorry, you are following the process as it is
> outlined. Please go ahead with the suggestion to
> update the test to use TestNG. The current state of the PR should not affect
> updates. BTW AFAIK, you should not ne
> Can I please get a review and a sponsor for a fix for the issue reported at
> https://bugs.openjdk.java.net/browse/JDK-8252767?
> As noted in that issue, the `sun.net.www.URLConnection#setRequestProperty` is
> throwing a `IllegalAccessError` instead
> of a `IllegalStateException`. The commit her
On Mon, 7 Sep 2020 09:37:23 GMT, Chris Hegarty wrote:
>> Slightly OT - but I think this `/integrate` command shouldn't actually be in
>> the hands of the contributor and instead
>> should be decided and issued by "committers" or "sponsors". I don't really
>> see how the contributor/author can
>
On Mon, 7 Sep 2020 09:35:16 GMT, Jaikiran Pai wrote:
>>> I see Jaikiran has used "/integrate" but I don't think the review is
>>> complete yet. The change may be trivial but it's
>>> really important to give others a chance to comment if they wish.
>>
>> Sorry, I'm new this whole flow. I saw th
On Mon, 7 Sep 2020 09:31:02 GMT, Jaikiran Pai wrote:
>> I see Jaikiran has used "/integrate" but I don't think the review is
>> complete yet. The change may be trivial but it's
>> really important to give others a chance to comment if they wish.
>
>> I see Jaikiran has used "/integrate" but I do
On Mon, 7 Sep 2020 09:28:39 GMT, Alan Bateman wrote:
> I see Jaikiran has used "/integrate" but I don't think the review is complete
> yet. The change may be trivial but it's
> really important to give others a chance to comment if they wish.
Sorry, I'm new this whole flow. I saw the message fr
On Mon, 7 Sep 2020 09:24:06 GMT, Alan Bateman wrote:
> Given that the test update is significant then it makes me wonder if we
> should just move to TestNG while we're at it.
> It would avoid needing to add expectIllegalStateException.
I wasn't sure if it was OK to do it as part of this change.
On Mon, 7 Sep 2020 09:15:13 GMT, Chris Hegarty wrote:
>> Jaikiran Pai has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental
>> views will show differences compared to the previous content of the PR. The
>> pull request contains one new commi
On Mon, 7 Sep 2020 09:18:31 GMT, Jaikiran Pai wrote:
>> Can I please get a review and a sponsor for a fix for the issue reported at
>> https://bugs.openjdk.java.net/browse/JDK-8252767?
>> As noted in that issue, the `sun.net.www.URLConnection#setRequestProperty`
>> is throwing a `IllegalAccessEr
> Can I please get a review and a sponsor for a fix for the issue reported at
> https://bugs.openjdk.java.net/browse/JDK-8252767?
> As noted in that issue, the `sun.net.www.URLConnection#setRequestProperty` is
> throwing a `IllegalAccessError` instead
> of a `IllegalStateException`. The commit her
On Mon, 7 Sep 2020 08:33:17 GMT, Chris Hegarty wrote:
>> Jaikiran Pai has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental
>> views will show differences compared to the previous content of the PR. The
>> pull request contains one new commi
On Mon, 7 Sep 2020 09:15:39 GMT, Jaikiran Pai wrote:
>> Can I please get a review and a sponsor for a fix for the issue reported at
>> https://bugs.openjdk.java.net/browse/JDK-8252767?
>> As noted in that issue, the `sun.net.www.URLConnection#setRequestProperty`
>> is throwing a `IllegalAccessEr
On Sun, 6 Sep 2020 11:21:58 GMT, Jaikiran Pai wrote:
>> Can I please get a review and a sponsor for a fix for the issue reported at
>> https://bugs.openjdk.java.net/browse/JDK-8252767?
>> As noted in that issue, the `sun.net.www.URLConnection#setRequestProperty`
>> is throwing a `IllegalAccessEr
On Sun, 6 Sep 2020 10:56:44 GMT, Alan Bateman wrote:
> The URL creation isn't technically right as you can't reliably use a file
> path string as a URL path. Something like the
> following would be more correct:
URL url = Path.of(System.getProperty("java.io.tmpdir")).toUri().toURL();
I've now u
> Can I please get a review and a sponsor for a fix for the issue reported at
> https://bugs.openjdk.java.net/browse/JDK-8252767?
> As noted in that issue, the `sun.net.www.URLConnection#setRequestProperty` is
> throwing a `IllegalAccessError` instead
> of a `IllegalStateException`. The commit her
On Sun, 6 Sep 2020 09:38:09 GMT, Jaikiran Pai wrote:
>> Can I please get a review and a sponsor for a fix for the issue reported at
>> https://bugs.openjdk.java.net/browse/JDK-8252767?
>> As noted in that issue, the `sun.net.www.URLConnection#setRequestProperty`
>> is throwing a `IllegalAccessEr
On Sun, 6 Sep 2020 09:11:52 GMT, Jaikiran Pai wrote:
>> test/jdk/sun/net/www/URLConnectionTest.java line 36:
>>
>>> 34: * @run testng URLConnectionTest
>>> 35: */
>>> 36: public class URLConnectionTest {
>>
>> I think it would be better to put the test in
>> test/jdk/java/net/URLConnection a
> Can I please get a review and a sponsor for a fix for the issue reported at
> https://bugs.openjdk.java.net/browse/JDK-8252767?
> As noted in that issue, the `sun.net.www.URLConnection#setRequestProperty` is
> throwing a `IllegalAccessError` instead
> of a `IllegalStateException`. The commit her
On Sun, 6 Sep 2020 09:05:55 GMT, Alan Bateman wrote:
>> Can I please get a review and a sponsor for a fix for the issue reported at
>> https://bugs.openjdk.java.net/browse/JDK-8252767?
>> As noted in that issue, the `sun.net.www.URLConnection#setRequestProperty`
>> is throwing a `IllegalAccessEr
On Sun, 6 Sep 2020 05:46:42 GMT, Jaikiran Pai wrote:
> Can I please get a review and a sponsor for a fix for the issue reported at
> https://bugs.openjdk.java.net/browse/JDK-8252767?
> As noted in that issue, the `sun.net.www.URLConnection#setRequestProperty` is
> throwing a `IllegalAccessError`
On Sun, 6 Sep 2020 05:46:42 GMT, Jaikiran Pai wrote:
> Can I please get a review and a sponsor for a fix for the issue reported at
> https://bugs.openjdk.java.net/browse/JDK-8252767?
> As noted in that issue, the `sun.net.www.URLConnection#setRequestProperty` is
> throwing a `IllegalAccessError`
30 matches
Mail list logo
