On Sun, 6 Sep 2020 09:11:52 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> test/jdk/sun/net/www/URLConnectionTest.java line 36:
>>
>>> 34: * @run testng URLConnectionTest
>>> 35: */
>>> 36: public class URLConnectionTest {
>>
>> I think it would be better to put the test in
>> test/jdk/java/net/URLConnection as its a test for
>> URLConnection.setRequestProperty from the API user point of view. Also it's
>> a a specific test for the behaviour of one
>> method so I think needs a more specific name too ("URLConnectionTest" is too
>> general)
>
> Hello Alan,
>
> There's a `test/jdk/java/net/URLConnection/RequestProperties.java` test class
> which tests the `setRequestProperty` for
> `NullPointerException` expectations of that API. Perhaps it would be OK to
> add this test into that class?
I've now updated this PR to move the test into
`test/jdk/java/net/URLConnection/RequestProperties.java`
-------------
PR: https://git.openjdk.java.net/jdk/pull/26
