On Sun, 15 May 2022 06:43:27 GMT, Jaikiran Pai wrote:
>> This change proposes to implement the enhancement noted in
>> https://bugs.openjdk.java.net/browse/JDK-8209137.
>>
>> The change introduces a new API to allow applications to build a
>> `java.net.http.HTTPClient` configured with a specif
On Sun, 15 May 2022 06:43:27 GMT, Jaikiran Pai wrote:
>> This change proposes to implement the enhancement noted in
>> https://bugs.openjdk.java.net/browse/JDK-8209137.
>>
>> The change introduces a new API to allow applications to build a
>> `java.net.http.HTTPClient` configured with a specif
On Sun, 15 May 2022 06:43:27 GMT, Jaikiran Pai wrote:
>> This change proposes to implement the enhancement noted in
>> https://bugs.openjdk.java.net/browse/JDK-8209137.
>>
>> The change introduces a new API to allow applications to build a
>> `java.net.http.HTTPClient` configured with a specif
On Sun, 15 May 2022 06:43:27 GMT, Jaikiran Pai wrote:
>> This change proposes to implement the enhancement noted in
>> https://bugs.openjdk.java.net/browse/JDK-8209137.
>>
>> The change introduces a new API to allow applications to build a
>> `java.net.http.HTTPClient` configured with a specif
> This change proposes to implement the enhancement noted in
> https://bugs.openjdk.java.net/browse/JDK-8209137.
>
> The change introduces a new API to allow applications to build a
> `java.net.http.HTTPClient` configured with a specific local address that will
> be used while creating `Socket`
On Tue, 10 May 2022 13:51:37 GMT, Jaikiran Pai wrote:
>> This change proposes to implement the enhancement noted in
>> https://bugs.openjdk.java.net/browse/JDK-8209137.
>>
>> The change introduces a new API to allow applications to build a
>> `java.net.http.HTTPClient` configured with a specif
On Wed, 11 May 2022 11:34:33 GMT, Michael McMahon wrote:
>> Hello Michael,
>> Most users will be using the `HttpClient.newBuilder()` to create the
>> builder, so this note about `UnsupportedOperationException` can be
>> confusing. However, for implementations (libraries?) which provide their
On Wed, 11 May 2022 08:54:48 GMT, Jaikiran Pai wrote:
>> src/java.net.http/share/classes/java/net/http/HttpClient.java line 378:
>>
>>> 376: *
>>> 377: * @implSpec The default implementation of this method throws
>>> 378: * {@code UnsupportedOperationException}. {@code
On Wed, 11 May 2022 08:12:12 GMT, Michael McMahon wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix javadoc link in test
>
> src/java.net.http/share/classes/java/net/http/HttpClient.java line 378:
>
>> 376:
On Tue, 10 May 2022 13:51:37 GMT, Jaikiran Pai wrote:
>> This change proposes to implement the enhancement noted in
>> https://bugs.openjdk.java.net/browse/JDK-8209137.
>>
>> The change introduces a new API to allow applications to build a
>> `java.net.http.HTTPClient` configured with a specif
On Tue, 10 May 2022 13:51:37 GMT, Jaikiran Pai wrote:
>> This change proposes to implement the enhancement noted in
>> https://bugs.openjdk.java.net/browse/JDK-8209137.
>>
>> The change introduces a new API to allow applications to build a
>> `java.net.http.HTTPClient` configured with a specif
On Tue, 10 May 2022 13:35:35 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Daniel's review suggestion - add a test to verify the behaviour of the
>> localAddress() default method implementati
On Tue, 10 May 2022 12:37:47 GMT, Jaikiran Pai wrote:
>> This change proposes to implement the enhancement noted in
>> https://bugs.openjdk.java.net/browse/JDK-8209137.
>>
>> The change introduces a new API to allow applications to build a
>> `java.net.http.HTTPClient` configured with a specif
> This change proposes to implement the enhancement noted in
> https://bugs.openjdk.java.net/browse/JDK-8209137.
>
> The change introduces a new API to allow applications to build a
> `java.net.http.HTTPClient` configured with a specific local address that will
> be used while creating `Socket`
On Tue, 10 May 2022 13:36:18 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Daniel's review suggestion - add a test to verify the behaviour of the
>> localAddress() default method implementati
On Tue, 10 May 2022 12:37:47 GMT, Jaikiran Pai wrote:
>> This change proposes to implement the enhancement noted in
>> https://bugs.openjdk.java.net/browse/JDK-8209137.
>>
>> The change introduces a new API to allow applications to build a
>> `java.net.http.HTTPClient` configured with a specif
On Mon, 9 May 2022 13:31:38 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 37 commits:
>>
>> - Merge latest from master branch
>> - add a @build to force jtreg to show consistent test re
> This change proposes to implement the enhancement noted in
> https://bugs.openjdk.java.net/browse/JDK-8209137.
>
> The change introduces a new API to allow applications to build a
> `java.net.http.HTTPClient` configured with a specific local address that will
> be used while creating `Socket`
On Mon, 9 May 2022 07:52:29 GMT, Jaikiran Pai wrote:
>> This change proposes to implement the enhancement noted in
>> https://bugs.openjdk.java.net/browse/JDK-8209137.
>>
>> The change introduces a new API to allow applications to build a
>> `java.net.http.HTTPClient` configured with a specifi
> This change proposes to implement the enhancement noted in
> https://bugs.openjdk.java.net/browse/JDK-8209137.
>
> The change introduces a new API to allow applications to build a
> `java.net.http.HTTPClient` configured with a specific local address that will
> be used while creating `Socket`
On Mon, 4 Apr 2022 09:53:02 GMT, Jaikiran Pai wrote:
>> This change proposes to implement the enhancement noted in
>> https://bugs.openjdk.java.net/browse/JDK-8209137.
>>
>> The change introduces a new API to allow applications to build a
>> `java.net.http.HTTPClient` configured with a specifi
> This change proposes to implement the enhancement noted in
> https://bugs.openjdk.java.net/browse/JDK-8209137.
>
> The change introduces a new API to allow applications to build a
> `java.net.http.HTTPClient` configured with a specific local address that will
> be used while creating `Socket`
On Mon, 6 Dec 2021 14:39:27 GMT, Jaikiran Pai wrote:
>> Also it's better if the test is IP version agnostic.
>
> Hello Daniel, I will update the test accordingly in the next round of updates.
I'd suggest HttpClientLocalAddrTest implements HttpServerAdapters like other
tests do.
-
On Mon, 4 Apr 2022 09:53:02 GMT, Jaikiran Pai wrote:
>> This change proposes to implement the enhancement noted in
>> https://bugs.openjdk.java.net/browse/JDK-8209137.
>>
>> The change introduces a new API to allow applications to build a
>> `java.net.http.HTTPClient` configured with a specifi
On Mon, 4 Apr 2022 09:52:56 GMT, Jaikiran Pai wrote:
>> src/java.net.http/share/classes/jdk/internal/net/http/HttpClientBuilderImpl.java
>> line 140:
>>
>>> 138: return this;
>>> 139: }
>>> 140:
>>
>> Either this should check that localAddr is an `InetSocketAddress` and that
>> p
On Thu, 24 Mar 2022 06:46:01 GMT, Jaikiran Pai wrote:
>> This change proposes to implement the enhancement noted in
>> https://bugs.openjdk.java.net/browse/JDK-8209137.
>>
>> The change introduces a new API to allow applications to build a
>> `java.net.http.HTTPClient` configured with a specif
> This change proposes to implement the enhancement noted in
> https://bugs.openjdk.java.net/browse/JDK-8209137.
>
> The change introduces a new API to allow applications to build a
> `java.net.http.HTTPClient` configured with a specific local address that will
> be used while creating `Socket`
> This change proposes to implement the enhancement noted in
> https://bugs.openjdk.java.net/browse/JDK-8209137.
>
> The change introduces a new API to allow applications to build a
> `java.net.http.HTTPClient` configured with a specific local address that will
> be used while creating `Socket`
> This change proposes to implement the enhancement noted in
> https://bugs.openjdk.java.net/browse/JDK-8209137.
>
> The change introduces a new API to allow applications to build a
> `java.net.http.HTTPClient` configured with a specific local address that will
> be used while creating `Socket`
> This change proposes to implement the enhancement noted in
> https://bugs.openjdk.java.net/browse/JDK-8209137.
>
> The change introduces a new API to allow applications to build a
> `java.net.http.HTTPClient` configured with a specific local address that will
> be used while creating `Socket`
On Wed, 2 Feb 2022 10:37:54 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> minor - rename variable in test
>
> src/java.net.http/share/classes/java/net/http/HttpClient.java line 376:
>
>> 374:
> This change proposes to implement the enhancement noted in
> https://bugs.openjdk.java.net/browse/JDK-8209137.
>
> The change introduces a new API to allow applications to build a
> `java.net.http.HTTPClient` configured with a specific local address that will
> be used while creating `Socket`
On Tue, 7 Dec 2021 14:28:01 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> minor - rename variable in test
>
> Generally it would be good if the test did not make any assumption on the
> presenc
On Wed, 2 Feb 2022 06:18:39 GMT, Jaikiran Pai wrote:
>> This change proposes to implement the enhancement noted in
>> https://bugs.openjdk.java.net/browse/JDK-8209137.
>>
>> The change introduces a new API to allow applications to build a
>> `java.net.http.HTTPClient` configured with a specifi
> This change proposes to implement the enhancement noted in
> https://bugs.openjdk.java.net/browse/JDK-8209137.
>
> The change introduces a new API to allow applications to build a
> `java.net.http.HTTPClient` configured with a specific local address that will
> be used while creating `Socket`
On Tue, 7 Dec 2021 14:28:01 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> minor - rename variable in test
>
> Generally it would be good if the test did not make any assumption on the
> presenc
> This change proposes to implement the enhancement noted in
> https://bugs.openjdk.java.net/browse/JDK-8209137.
>
> The change introduces a new API to allow applications to build a
> `java.net.http.HTTPClient` configured with a specific local address that will
> be used while creating `Socket`
> This change proposes to implement the enhancement noted in
> https://bugs.openjdk.java.net/browse/JDK-8209137.
>
> The change introduces a new API to allow applications to build a
> `java.net.http.HTTPClient` configured with a specific local address that will
> be used while creating `Socket`
On Wed, 12 Jan 2022 08:48:12 GMT, Jaikiran Pai wrote:
>> This change proposes to implement the enhancement noted in
>> https://bugs.openjdk.java.net/browse/JDK-8209137.
>>
>> The change introduces a new API to allow applications to build a
>> `java.net.http.HTTPClient` configured with a specif
> This change proposes to implement the enhancement noted in
> https://bugs.openjdk.java.net/browse/JDK-8209137.
>
> The change introduces a new API to allow applications to build a
> `java.net.http.HTTPClient` configured with a specific local address that will
> be used while creating `Socket`
> This change proposes to implement the enhancement noted in
> https://bugs.openjdk.java.net/browse/JDK-8209137.
>
> The change introduces a new API to allow applications to build a
> `java.net.http.HTTPClient` configured with a specific local address that will
> be used while creating `Socket`
> This change proposes to implement the enhancement noted in
> https://bugs.openjdk.java.net/browse/JDK-8209137.
>
> The change introduces a new API to allow applications to build a
> `java.net.http.HTTPClient` configured with a specific local address that will
> be used while creating `Socket`
> This change proposes to implement the enhancement noted in
> https://bugs.openjdk.java.net/browse/JDK-8209137.
>
> The change introduces a new API to allow applications to build a
> `java.net.http.HTTPClient` configured with a specific local address that will
> be used while creating `Socket`
> This change proposes to implement the enhancement noted in
> https://bugs.openjdk.java.net/browse/JDK-8209137.
>
> The change introduces a new API to allow applications to build a
> `java.net.http.HTTPClient` configured with a specific local address that will
> be used while creating `Socket`
On Wed, 8 Dec 2021 01:22:50 GMT, Jaikiran Pai wrote:
>> You could also replace `Boolean.getBoolean("java.net.preferIPv6Addresses")`
>> with a call to `IPSupport::preferIPv6Addresses()`
>
>> ::1 is the ipv6 loopback - not the ipv6 wildcard
>
> Oops, that's embarrassing and it isn't even a copy/p
On Tue, 7 Dec 2021 14:35:27 GMT, Daniel Fuchs wrote:
>> You may encounter some issues when testing with https and IPv6 - Michael is
>> working on a fix to add the loopback addresses as SNI aliases to the
>> SimpleSSLContext certificate:
>> https://bugs.openjdk.java.net/browse/JDK-8278312
>
> Yo
On Tue, 7 Dec 2021 14:33:40 GMT, Daniel Fuchs wrote:
>> test/jdk/java/net/httpclient/HttpClientLocalAddrTest.java line 205:
>>
>>> 203: // anyAddress
>>> 204: if (Boolean.getBoolean("java.net.preferIPv6Addresses")) {
>>> 205: // ipv6 wildcard
>>
>> ::1 is
On Fri, 3 Dec 2021 17:28:25 GMT, Daniel Fuchs wrote:
>> This change proposes to implement the enhancement noted in
>> https://bugs.openjdk.java.net/browse/JDK-8209137.
>>
>> The change introduces a new API to allow applications to build a
>> `java.net.http.HTTPClient` configured with a specifi
On Fri, 3 Dec 2021 17:29:44 GMT, Daniel Fuchs wrote:
>> test/jdk/java/net/httpclient/HttpClientLocalAddrTest.java line 74:
>>
>>> 72:
>>> 73: @BeforeClass
>>> 74: public static void beforeClass() throws Exception {
>>
>> For HttpClient tests - unless they are specific to HTTP/1.1 I'd r
On Fri, 3 Dec 2021 06:15:31 GMT, Jaikiran Pai wrote:
> This change proposes to implement the enhancement noted in
> https://bugs.openjdk.java.net/browse/JDK-8209137.
>
> The change introduces a new API to allow applications to build a
> `java.net.http.HTTPClient` configured with a specific loc
50 matches
Mail list logo
