On 21/08/2019 11:51, Alan Bateman wrote:
We could make those two methods return void and throw the
SkipException themselves? I don't mind doing that change in this patch.
I don't want to expand the scope of your changes, it was just a passing
comment. I think returning boolean is fine, I just th
On 21/08/2019 11:45, Nick Gasson wrote:
On 21/08/2019 18:30, Alan Bateman wrote:
Daniel - if there are other changes to this test then it might be worth
re-examining the ensureXXX methods. The naming is very strange as they
return a boolean. Also they print messages to say that the test is
skip
On 21/08/2019 18:30, Alan Bateman wrote:
Daniel - if there are other changes to this test then it might be worth
re-examining the ensureXXX methods. The naming is very strange as they
return a boolean. Also they print messages to say that the test is
skipped but it's the caller that will determi
On 21/08/2019 11:09, Nick Gasson wrote:
Hi,
Thanks Alan and Daniel for the suggestions. I've made these changes here:
http://cr.openjdk.java.net/~ngasson/8229912/webrev.1/
This looks okay to me.
Daniel - if there are other changes to this test then it might be worth
re-examining the ensur
Hi,
Thanks Alan and Daniel for the suggestions. I've made these changes here:
http://cr.openjdk.java.net/~ngasson/8229912/webrev.1/
Nick
On 21/08/2019 17:05, Daniel Fuchs wrote:
Hi Nick,
Thanks for finding this issue and proposing a fix.
I agree with Alan that throwing SkipException would b
Hi Nick,
Thanks for finding this issue and proposing a fix.
I agree with Alan that throwing SkipException would be a better
choice, we have started using that more frequently recently.
In addition jdk.test.lib.NetworkConfiguration [1] provides a
static printSystemConfiguration method that could
On 21/08/2019 07:55, Nick Gasson wrote:
Hi,
Bug: https://bugs.openjdk.java.net/browse/JDK-8229912
Webrev: http://cr.openjdk.java.net/~ngasson/8229912/webrev.0/
This test should be skipped if IPv6 is disabled on the host, and it
already has a shouldRun field to support this. But at the moment th
