Re: @since tag missing from DatagramSocket and MulticastSocket methods

2020-01-14 Thread Chris Hegarty
LGTM. Surprising that we haven’t noticed this before, because the @since tags are used, in part, to derive the symbol tables for --release ( maybe such old version information is not useful these days ) -Chris. > On 14 Jan 2020, at 11:49, Patrick Concannon > wrote: > > Hi, > > Could someon

Re: @since tag missing from DatagramSocket and MulticastSocket methods

2020-01-14 Thread Daniel Fuchs
On 14/01/2020 11:49, Patrick Concannon wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8237075 webrev: http://cr.openjdk.java.net/~pconcannon/8237075/webrevs/webrev.00/ Looks good to me as well. best regards, -- daniel

Re: @since tag missing from DatagramSocket and MulticastSocket methods

2020-01-14 Thread Alan Bateman
On 14/01/2020 11:49, Patrick Concannon wrote: Hi, Could someone please review my fix for JDK-8237075 '@since tag missing from DatagramSocket and MulticastSocket methods' ? This trivial fix adds in the missing @since tags for methods listed below. These methods were originally added in JDK 1.