LGTM. Surprising that we haven’t noticed this before, because the @since tags are used, in part, to derive the symbol tables for --release ( maybe such old version information is not useful these days )
-Chris. > On 14 Jan 2020, at 11:49, Patrick Concannon <patrick.concan...@oracle.com> > wrote: > > Hi, > > Could someone please review my fix for JDK-8237075 '@since tag missing from > DatagramSocket and MulticastSocket methods' ? > > This trivial fix adds in the missing @since tags for methods listed below. > These methods were originally added in JDK 1.2. > > java/net/DatagramSocket: > > > public void connect(InetAddress address, int port) > > public void disconnect() > > public InetAddress getInetAddress() > > public int getPort() > > public synchronized void setSendBufferSize(int size) > > public synchronized int getSendBufferSize() throws SocketException > > public synchronized void setReceiveBufferSize(int size) > > public synchronized int getReceiveBufferSize() > > java/net/MulticastSocket: > > > public void setTimeToLive(int ttl) > > public int getTimeToLive() > > > bug: https://bugs.openjdk.java.net/browse/JDK-8237075 > > webrev: http://cr.openjdk.java.net/~pconcannon/8237075/webrevs/webrev.00/ > > > Kind regards, > > Patrick >
