Re: RFR 8245307 : Update ExchangeImpl to use thread safe DateTimeFormatter

Hi Daniel, I have updated the copyright notice. On 15/06/2020 16:23, Daniel Fuchs wrote: Hi Rahul, Sorry I didn't catch that earlier, but your test has the wrong copyright notice. We do not have the "Classpath" exception in tests. best regards, -- daniel On 15/06/2020 11:41, Rahul Yadav wro

Re: RFR 8245307 : Update ExchangeImpl to use thread safe DateTimeFormatter

Hi Rahul, Sorry I didn't catch that earlier, but your test has the wrong copyright notice. We do not have the "Classpath" exception in tests. best regards, -- daniel On 15/06/2020 11:41, Rahul Yadav wrote: Hi Chris, Daniel Thank you for the comments. I have included the feedback and updated

Re: RFR 8245307 : Update ExchangeImpl to use thread safe DateTimeFormatter

Thanks Rahul! Looks good to me too :-) best regards, -- daniel On 15/06/2020 11:41, Rahul Yadav wrote: Hi Chris, Daniel Thank you for the comments. I have included the feedback and updated webrev. http://cr.openjdk.java.net/~ryadav/webrev_8245307/index.html - rahul

Re: RFR 8245307 : Update ExchangeImpl to use thread safe DateTimeFormatter

> On 15 Jun 2020, at 11:41, Rahul Yadav wrote: > > Hi Chris, Daniel > > Thank you for the comments. > I have included the feedback and updated webrev. > > http://cr.openjdk.java.net/~ryadav/webrev_8245307/index.html > > LGTM. Sh

Re: RFR 8245307 : Update ExchangeImpl to use thread safe DateTimeFormatter

Hi Chris, Daniel Thank you for the comments. I have included the feedback and updated webrev. http://cr.openjdk.java.net/~ryadav/webrev_8245307/index.html - rahul On 15/06/2020 10:28, Daniel Fuchs wrote: Hi Rahul, On 15/06/2020 09:52, Chris Hegarty wrote: On 12 Jun 2020, at 17:55, Rahul Ya

Re: RFR 8245307 : Update ExchangeImpl to use thread safe DateTimeFormatter

Hi Rahul, On 15/06/2020 09:52, Chris Hegarty wrote: On 12 Jun 2020, at 17:55, Rahul Yadav > wrote: ... http://cr.openjdk.java.net/~ryadav/webrev_8245307/index.html 2) While not wrong, I don’t think that the @library tag is needed, or at least I cannot see

Re: RFR 8245307 : Update ExchangeImpl to use thread safe DateTimeFormatter

> On 12 Jun 2020, at 17:55, Rahul Yadav wrote: > > ... > > http://cr.openjdk.java.net/~ryadav/webrev_8245307/index.html > This looks v. good Rahul. A few, mostly pedantic, comments on the test: 1) In recent times, we’ve been bi

Re: RFR 8245307 : Update ExchangeImpl to use thread safe DateTimeFormatter

On 12/06/2020 17:55, Rahul Yadav wrote: Hi Alan, Thank you for the feedback. I have updated the webrev. http://cr.openjdk.java.net/~ryadav/webrev_8245307/index.html Thank for the update, this looks good. Minor nit is that we typically use order the modifiers so that it's "static final" rather

Re: RFR 8245307 : Update ExchangeImpl to use thread safe DateTimeFormatter

Hi Alan, Thank you for the feedback. I have updated the webrev.  http://cr.openjdk.java.net/~ryadav/webrev_8245307/index.html - rahul On 12/06/2020 16:57, Alan Bateman wrote: On 12/06/2020 15:56, Rahul wrote: Hello, Request to have my fix reviewed for the issue: JDK-8245307 : Update Exc

RFR 8245307 : Update ExchangeImpl to use thread safe DateTimeFormatter

Hello, Request to have my fix reviewed for the issue: JDK-8245307 : Update ExchangeImpl to use thread safe DateTimeFormatter. The fix updates sun.net.httpserver.ExchangeImpl to use thread safe DateTimeFormatter for response headers, this replaces DateFormat that was using ThreadLocal

Re: RFR 8245307 : Update ExchangeImpl to use thread safe DateTimeFormatter

On 12/06/2020 15:56, Rahul wrote: Hello, Request to have my fix reviewed for the issue: JDK-8245307 : Update ExchangeImpl to use thread safe DateTimeFormatter. The fix updates sun.net.httpserver.ExchangeImpl to use thread safe DateTimeFormatter for response headers, this replaces DateForma

RFR 8245307 : Update ExchangeImpl to use thread safe DateTimeFormatter

Hello, Request to have my fix reviewed for the issue: JDK-8245307 : Update ExchangeImpl to use thread safe DateTimeFormatter. The fix updates sun.net.httpserver.ExchangeImpl to use thread safe DateTimeFormatter for response headers, this replaces DateFormat that was using ThreadLocal