> On 12 Jun 2020, at 17:55, Rahul Yadav <[email protected]> wrote:
>
> ...
>
> http://cr.openjdk.java.net/~ryadav/webrev_8245307/index.html
> <http://cr.openjdk.java.net/~ryadav/webrev_8245307/index.html>
This looks v. good Rahul.
A few, mostly pedantic, comments on the test:
1) In recent times, we’ve been binding our test servers explicitly to:
InetSocketAddress(InetAddress.getLoopbackAddress(), 0);
2) While not wrong, I don’t think that the @library tag is needed, or at least
I cannot see why.
3) L109 "byte [] bytes = is.readAllBytes();” - please remove the space between
`byte` and the square brackets
Overall this is a nice change.
-Chris
