Re: RFR 8055747: Move SimpleSSLContext to jdk/testlibrary

2014-08-25 Thread Michael McMahon
On 25/08/14 14:06, Chris Hegarty wrote: Michael, This looks mainly ok to me. It is nice to be adding to the common test infrastructure, where possible. Just a few minor comments... 1) Do the tests what use this also need to ensure that the classfile is compiled? We had trouble in the past

Re: RFR 8055747: Move SimpleSSLContext to jdk/testlibrary

2014-08-25 Thread Chris Hegarty
Michael, This looks mainly ok to me. It is nice to be adding to the common test infrastructure, where possible. Just a few minor comments... 1) Do the tests what use this also need to ensure that the classfile is compiled? We had trouble in the past when running concurrently. @build jd

RFR 8055747: Move SimpleSSLContext to jdk/testlibrary

2014-08-21 Thread Michael McMahon
Before I push the other change to HttpsURLConnection, I'd like to make this change to stop the proliferation of binary testkeys files in the test tree and make the SimpleSSLContext class more accessible. http://cr.openjdk.java.net/~michaelm/8055747/webrev.01/ Thanks, Michael