On 25/08/14 14:06, Chris Hegarty wrote:
Michael,
This looks mainly ok to me. It is nice to be adding to the common test
infrastructure, where possible. Just a few minor comments...
1) Do the tests what use this also need to ensure that the classfile is
compiled? We had trouble in the past when running concurrently.
@build jdk.testlibrary.SimpleSSLContext
Good question. I'll look into this. It's an annoying feature
of jtreg if it is the case.
2) For the purposes of the policy files it would be nice to be able to
specify the location relative to the TEST.ROOT, but I'm not sure if
jtreg provides a property, or other, to expose this.
I looked into it, and there's nothing usable in the environment
unfortunately. It's a pity TEST.ROOT isn't provided.
Thanks,
Michael
-Chris.
On 21/08/14 12:33, Michael McMahon wrote:
Before I push the other change to HttpsURLConnection, I'd like
to make this change to stop the proliferation of binary testkeys files
in the test tree and make the SimpleSSLContext class more accessible.
http://cr.openjdk.java.net/~michaelm/8055747/webrev.01/
Thanks,
Michael