Re: RFR 8043954: Fix behavior difference of connect() for AIX

Hi Alan, Volker, Thanks a lot! I've pushed the change. Best regards - Jonathan On Fri, Jun 6, 2014 at 8:27 PM, Volker Simonis wrote: > Hi Jonathan, > > I just wanted to let you know that I've build your changes on AIX 5..3 and > 7.1. > I've also run the jdk regression tests without specific

Re: RFR 8043954: Fix behavior difference of connect() for AIX

On 06/06/2014 11:03, Jonathan Lu wrote: You are right! errno will be checked by other code if NET_Connect() failed, I've updated the patch, please help to review. http://cr.openjdk.java.net/~luchsh/JDK-8043954.3/ Thanks for the update,

Re: RFR 8043954: Fix behavior difference of connect() for AIX

Hi Jonathan, I just wanted to let you know that I've build your changes on AIX 5..3 and 7.1. I've also run the jdk regression tests without specific issues. So thumbs up from me! Regards, Volker On Fri, Jun 6, 2014 at 12:03 PM, Jonathan Lu wrote: > Hi Alan, > > On Fri, Jun 6, 2014 at 1:53 AM,

Re: RFR 8043954: Fix behavior difference of connect() for AIX

Hi Alan, On Fri, Jun 6, 2014 at 1:53 AM, Alan Bateman wrote: > On 05/06/2014 11:37, Jonathan Lu wrote: > > > If getsockopt(SO_ERROR) failed, I did not find any explicit docs about > the behavior. > but as I tested with some C code snippet, the value of sockopt_arg would > not be changed if ge

Re: RFR 8043954: Fix behavior difference of connect() for AIX

On 05/06/2014 11:37, Jonathan Lu wrote: If getsockopt(SO_ERROR) failed, I did not find any explicit docs about the behavior. but as I tested with some C code snippet, the value of sockopt_arg would not be changed if getsockopt(SO_ERROR) failed. So I prefer to keep the current approach, does

Re: RFR 8043954: Fix behavior difference of connect() for AIX

Hi Alan, On Wed, Jun 4, 2014 at 9:16 PM, Alan Bateman wrote: > On 04/06/2014 07:31, Jonathan Lu wrote: > >> Hi Volker, >> >> Thanks for your comment! an updated webrev was made at >> http://cr.openjdk.java.net/~luchsh/JDK-8043954.2/ >> >> Would it make sense to set errno to sockopt_arg for the

Re: RFR 8043954: Fix behavior difference of connect() for AIX

On 04/06/2014 07:31, Jonathan Lu wrote: Hi Volker, Thanks for your comment! an updated webrev was made at http://cr.openjdk.java.net/~luchsh/JDK-8043954.2/ Would it make sense to set errno to sockopt_arg for the case that getsockopt(SO_ERROR) returns an error? Otherwise it looks okay to me.

Re: RFR 8043954: Fix behavior difference of connect() for AIX

Hi Volker, Thanks for your comment! an updated webrev was made at http://cr.openjdk.java.net/~luchsh/JDK-8043954.2/ On Tue, Jun 3, 2014 at 8:48 PM, Volker Simonis wrote: > Hi Jonathan, > > thanks for fixing this! I've looked at the change and it looks good to > me (but I'm not a reviewer). > Th

Re: RFR 8043954: Fix behavior difference of connect() for AIX

Hi Jonathan, thanks for fixing this! I've looked at the change and it looks good to me (but I'm not a reviewer). The only minor flaw I found is that you declare the helper variable 'int rc = -1' but never assign it. Instead you could just return '-1' directly where you currently return 'rc' and re

RFR 8043954: Fix behavior difference of connect() for AIX

Hello, Could I have following patch reviewed for bug 8034954 ? http://cr.openjdk.java.net/~luchsh/JDK-8043954/ The patch is to fix a behavior difference of connect() API for AIX platform, according to the documentation, http://www-01.ibm.com/support/knowledgecenter/ssw_aix_71/com.ibm.aix.commtrf